Describe the bug
If we have an external procedure in an external folder, which does not belong to the default paths, and we want to go to the definition, an error message appears that the name contains invalid characters.
To Reproduce
Steps to reproduce the behavior:
Create an external procedure
Reference that in an internal file (e.g. a script)
Select "Go to procedure definition" or press Ctrl+.
See error message
Expected behavior
The external procedure file should be opened up.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
OS: 10x64
Version v1.1.5.2303
Additional context
Add any other context about the problem here.
(Do not write below this line)
DEVS' SECTION
ANALYSIS
The problem is located in void NumeReEditor::FindAndOpenProcedure(const wxString& procedurename) in editor.cpp, where we test for invalid characters but do not distinguish between external and internal procedures. Instead we try to check both at the same time, which does not work, of course.
Change that so that external procedures (like $'PATH/TO/PROC/FILE'()) are checked for valid file names and simplify internal procedure checks.
DESCRIPTION
Describe the bug If we have an external procedure in an external folder, which does not belong to the default paths, and we want to go to the definition, an error message appears that the name contains invalid characters.
To Reproduce Steps to reproduce the behavior:
Expected behavior The external procedure file should be opened up.
Screenshots If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
Additional context Add any other context about the problem here.
(Do not write below this line)
DEVS' SECTION
ANALYSIS
The problem is located in
void NumeReEditor::FindAndOpenProcedure(const wxString& procedurename)ineditor.cpp, where we test for invalid characters but do not distinguish between external and internal procedures. Instead we try to check both at the same time, which does not work, of course.Change that so that external procedures (like
$'PATH/TO/PROC/FILE'()) are checked for valid file names and simplify internal procedure checks.IMPLEMENTATION STEPS
(see also our Wiki for implementation guidelines)
DOCUMENTATION STEPS
(see also our Wiki for further information)
*.NHLPand*.NDBfiles, if needed)*.NLNGfiles, if needed)PULL REQUEST