Clicking on the wrong place on the dependency viewer triggers a debug dialog

[numeredev]

DESCRIPTION

Describe the bug If we click on the wrong place in the dependency viewer, then a debug alert dialog is triggered.

To Reproduce Steps to reproduce the behavior:

1. Open the dependency viewer
2. Click on something, which is not part of the list
3. See error

Expected behavior This dialog should not appear.

Screenshots

Desktop (please complete the following information):

• OS: 10x64
• Version v1.1.5.2303

Additional context Add any other context about the problem here.

(Do not write below this line)

---

DEVS' SECTION

ANALYSIS

The problem is in void DependencyDialog::OnItemSelected(wxTreeEvent& event) in dependencydialog.cpp. Here, it isn't checked, whether the selected item is actually valid, i.e. event.GetItem().IsOk(). Add that check and only proceed, if it returns true.

IMPLEMENTATION STEPS

(see also our Wiki for implementation guidelines)

• Implement the necessary changes in a new branch created here on GitHub
• Test your implementation

DOCUMENTATION STEPS

(see also our Wiki for further information)

• Update the changes log
• Add comments to your implementation
• Add Doxygen documentation comments
• Create or update the documentation articles (*.NHLP and *.NDB files, if needed)
• Update the language strings (*.NLNG files, if needed)

PULL REQUEST

• Create a pull request for your changes
• Fill out the template
• Assign @numere-org/maintainers as reviewers