Implemented changes required by #65 - Githubissues

numere-org / NumeRe

Framework for numerical computations, data analysis and visualisation

https://www.numere.org

GNU General Public License v3.0

20 stars 7 forks source link

Implemented changes required by #65 #71

Closed numeredev closed 1 year ago

numeredev commented 1 year ago

SUMMARY

Implements necessary changes for #65

Reviewers: @numere-org/maintainers

IMPLEMENTATION

Implementation: Changed the behavior of StringArg StringVector::getArg(size_t i) const to always return an empty string in case of a missing argument.
Implementation test: Created a key-value list and used getkeyval() without the third parameter and the result was as intended.

DOCUMENTATION

[x] ChangesLog updated
[x] Code changes commented
Documentation articles:
- [ ] corresponding documentation articles updated
- [ ] new documentation articles created
- [x] not needed
Language files:
- [ ] corresponding language files updated
- [x] not needed

TESTS BY REVIEWERS

[x] Added to the automatic SW tests
[x] Tested manually

numeredev commented 1 year ago

Here's some code for testing:

kv{} = {"k1", 1, "k2", 2};
getkeyval(kv{}, "k1")
getkeyval(kv{}, "k")
getkeyval(kv{}, "k", "")