Implements changes required by #13 - Githubissues

numere-org / NumeRe

Framework for numerical computations, data analysis and visualisation

https://www.numere.org

GNU General Public License v3.0

18 stars 6 forks source link

Implements changes required by #13 #73

Closed numeredev closed 1 year ago

numeredev commented 1 year ago

SUMMARY

Implements necessary changes for #13

Reviewers: @numere-org/maintainers

IMPLEMENTATION

Implementation: Possible plotting options are now parsed directly as the parameters are now piped into the PlotData object directly. Had to rename the grid parameter of hist to asgrid due to name conflict.
Implementation test: Modified the plotting options while creating a simple histogram using hist.

DOCUMENTATION

[x] ChangesLog updated
[x] Code changes commented
Documentation articles:
- [x] corresponding documentation articles updated
- [ ] new documentation articles created
- [ ] not needed
Language files:
- [x] corresponding language files updated
- [ ] not needed

TESTS BY REVIEWERS

[ ] Added to the automatic SW tests
[x] Tested manually

raphael-sys commented 1 year ago

@numeredev How do we handle automatic tests for this? I do not know a feasible option to check if plot options have been applied successfully.

numeredev commented 1 year ago

Manual tests are enough for this change.