numere-org / NumeRe

Framework for numerical computations, data analysis and visualisation
https://www.numere.org
GNU General Public License v3.0
18 stars 6 forks source link

'copy' and 'move' cannot handle string columns #76

Closed numeredev closed 1 year ago

numeredev commented 1 year ago

DESCRIPTION

Describe the bug Copying a table containing string columns (or similar) with copy does only copy numerical values.

To Reproduce Steps to reproduce the behavior:

  1. Create a mixed table
  2. Create a target table
  3. Use copy to copy the contents between the tables (move should not be different)
  4. See error

Expected behavior The contents of the copied table as well as the column types are preserved (if possible)

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

(Do not write below this line)


DEVS' SECTION

ANALYSIS

The function static void performDataOperation(...) simply does not support the new column types and still only copies only numerical values. To resolve this, a complete rework of this function is needed. We recommend to use the NumeRe::Table class to obtain the elements the user wants to move or copy (via NumeRe::Table MemoryManager::extractTable(...)) and then create a more intelligent importer function similar to void MemoryManager::importTable(...) but supporting transposition and some small other changes.

IMPLEMENTATION STEPS

(see also our Wiki for implementation guidelines)

DOCUMENTATION STEPS

(see also our Wiki for further information)

PULL REQUEST