Describe the bug
Exporting a table, which contains multiple head rows (head rows containing a line break character), into an XLS file using the table viewer or the export command does not work but results in an app hang.
To Reproduce
Steps to reproduce the behavior:
Create a table with multiple table head rows
Enter export TABLE() -set file=FILENAME.xls
See error
Expected behavior
The table should be saved to a file.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
OS: 10x64
Version v1.1.5.2303
Additional context
Add any other context about the problem here.
(Do not write below this line)
DEVS' SECTION
ANALYSIS
The problem boils down to a typo in void XLSSpreadSheet::writeFile(), where a while loop replaces '\n' with (char)10 which is identical to '\n'. This should instead be (char)13 as can be seen in the opposite function void XLSSpreadSheet::readFile(). The used std::string::replace() seems also have some problems as two chars are replaced instead of one?
DESCRIPTION
Describe the bug Exporting a table, which contains multiple head rows (head rows containing a line break character), into an XLS file using the table viewer or the
export
command does not work but results in an app hang.To Reproduce Steps to reproduce the behavior:
export TABLE() -set file=FILENAME.xls
Expected behavior The table should be saved to a file.
Screenshots If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
Additional context Add any other context about the problem here.
(Do not write below this line)
DEVS' SECTION
ANALYSIS
The problem boils down to a typo in
void XLSSpreadSheet::writeFile()
, where awhile
loop replaces'\n'
with(char)10
which is identical to'\n'
. This should instead be(char)13
as can be seen in the opposite functionvoid XLSSpreadSheet::readFile()
. The usedstd::string::replace()
seems also have some problems as two chars are replaced instead of one?IMPLEMENTATION STEPS
(see also our Wiki for implementation guidelines)
DOCUMENTATION STEPS
(see also our Wiki for further information)
*.NHLP
and*.NDB
files, if needed)*.NLNG
files, if needed)PULL REQUEST