Is your change request related to a problem? Please describe.
If a data table with a mixture of values and true or false in the columns are loaded, then all values decay to logical values. This should not be the case.
Describe the solution you'd like
In this case, the automatic conversion should prefer simply numerical values (converting true and false to 0 and 1). Note that I still might want to force a conversion to logical values in this situation.
Describe possible alternatives you've considered
Alternatively, the automatic conversion should not convert at all in this sitution.
Additional context
Add any other context or screenshots about the feature request here.
(Do not write below this line)
DEVS' SECTION
ANALYSIS
The problem is located in TableColumn* StringColumn::convert(ColumnType type), where in case of doubt, the CONVTYPE_LOGICAL is preferred. This should not be the case, but instead it should stick with CONVTYPE_VALUE.
We must ensure that the conversion takes place nevertheless, so that might require that we check each value again (or we add true and false to std::complex<double> StrToCmplx(const std::string& sString))
DESCRIPTION
Is your change request related to a problem? Please describe. If a data table with a mixture of values and
trueorfalsein the columns are loaded, then all values decay to logical values. This should not be the case.Describe the solution you'd like In this case, the automatic conversion should prefer simply numerical values (converting
trueandfalseto0and1). Note that I still might want to force a conversion to logical values in this situation.Describe possible alternatives you've considered Alternatively, the automatic conversion should not convert at all in this sitution.
Additional context Add any other context or screenshots about the feature request here.
(Do not write below this line)
DEVS' SECTION
ANALYSIS
TableColumn* StringColumn::convert(ColumnType type), where in case of doubt, theCONVTYPE_LOGICALis preferred. This should not be the case, but instead it should stick withCONVTYPE_VALUE.trueandfalsetostd::complex<double> StrToCmplx(const std::string& sString))IMPLEMENTATION STEPS
(see also our Wiki for implementation guidelines)
DOCUMENTATION STEPS
(see also our Wiki for further information)
*.NHLPand*.NDBfiles, if needed)*.NLNGfiles, if needed)PULL REQUEST