numere-org / NumeRe

Framework for numerical computations, data analysis and visualisation
https://www.numere.org
GNU General Public License v3.0
20 stars 7 forks source link

Index vectors with 'plot3d' show errors #87

Closed numeredev closed 1 year ago

numeredev commented 1 year ago

DESCRIPTION

Describe the bug If one uses this command line with a three-column table, then a strange message occurs: plot3d matrix(:,{3,1,2}) -set coords=cartesian

To Reproduce Steps to reproduce the behavior:

  1. Create a three-column table
  2. Execute the command line with this table
  3. See error

Expected behavior The plot is correclty reproduced

Screenshots grafik

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

(Do not write below this line)


DEVS' SECTION

ANALYSIS

The problem is in lines 4189ff in plotting.cpp, where "plot3d" is excluded explicitly. This should be converted into something like the following, where the third parameter enables the additonal square brackets.

if (sArg_2 == "<<empty>>" && sArg_3 == "<<empty>>")
{
    // Only one index or an index vector
    sTemp = "\"" + constructDataLegendElement(sArg_1, sTableName, _pInfo.sCommand != "plot3d") + "\"";
}

IMPLEMENTATION STEPS

(see also our Wiki for implementation guidelines)

DOCUMENTATION STEPS

(see also our Wiki for further information)

PULL REQUEST