search

numerical-mooc / assignment-bank

Contribute alternative assignments for Numerical Methods with Python
MIT License
14 stars 75 forks source link

FrankGonzales_1DWavebar #14

Closed fgonzales7 closed 9 years ago

fgonzales7 commented 9 years ago

Professor Barba,

I would appreciate if you could review my project notebook and provide any feedback. Thanks.

labarba commented 9 years ago

Sorry for taking a long time to give you feedback on your submission. It's a nice addition, since we did not discuss the standard wave equation in the course.

Note that your equation (1) is written with first-order derivatives. This is a typo. And I can't see the images embedded in the notebook; maybe a path issue, but we can fix this after merging your PR. More important is the fact that the images come from the lecture notes of G. Everstine (Fig. 14, page 23, and Fig. 22 in page 30) and you forgot to add a credit in the figure caption. You need to credit images that you include under fair use.

I found it confusing when you use a prime to denote the partial derivative of u with respect to x, because primes are used derivatives for functions of only one variable. I see that this notation comes from Everstine's notes, but you changed notation. It's just confusing. Presenting the non-reflecting boundary condition is one of the main contributions of your submission to the numericalmooc "knowledge base," so it would be nice to improve the explanation here.

Nice job, though. I'll merge your PR and we can do some little fixes later.

fgonzales7 commented 9 years ago

Professor Barba,

Thank you for the insightful feedback on my project.

When do you need me to implement the fixes you recommended on my project? I will be going out of town until Jan 5 and will have limited internet connectivity.

Happy Holidays!

labarba commented 9 years ago

I have fixed the typo in the wave equation, added image credits, and changed u' for f' (this makes better sense, because f is a function of one argument only).

You don't really have to do anything, but if you feel like you would like to improve the explanation of the non-reflecting boundary condition later on, you could open an new PR. That would be on a volunteer basis, and sincerely appreciated. But you don't have to.