search

numerical-mooc / assignment-bank

Contribute alternative assignments for Numerical Methods with Python
MIT License
14 stars 75 forks source link

adding final project by siddarth jeripotula #30

Closed siddarth407 closed 9 years ago

siddarth407 commented 9 years ago

Adding my final project- Siddarth

labarba commented 9 years ago

It's very nice that you have completed the treatment of boundary conditions given in the course notes with this discussion of the Robin BC. It's also nice that you give a physical interpretation in your re-formulation of the microchip problem from the course.

In the presentation of boundary conditions, the bottom, left and right BCs are repeated from the class notes. It's in poor form to simply copy over the material from the class notes, so it would be better so simply write the equations and make a reference to the class notes.

I guess a lot of the notebook from then on follows closely the course material (Module 4, lesson 4) and if you want this notebook to be self-contained, you had to include it. Maybe what you could have done is explain in a short paragraph how much of the material is being re-used, and what is really new. With a little re-organization, you could more cleanly mark what is your contribution. (Even the Python functions are mostly from the course lesson, and you could indicate with a comment where you had to make a code change to implement the Robin BC.)

It kind of gets trying to have to re-write the matrix-construction function each time you want to change boundary conditions, don't you think? (and the rhs construction, too)

Can you imagine a way in which you might write the code so that the matrix constructor is just one function, but you have some logic inside it so that you can apply any type of boundary conditions you need on each domain edge?

Typos: two-dimentional —> two-dimensional Robin —> should be capitalized bounday —> boundary boundry —> boundary lets —> let's (contraction of "let us") impipedance —> impedance refreash —> refresh (but better to say "review") lets —> let's (contraction of "let us") (again below, several times) this conditions —> these conditions

for diffusivity, you missed a backslash in the units: \rm

say that the one of —> say that one of which is has —> which has advanse —> advance its not needed —> it's not needed switching of —> switching off Its clear —> It's clear Neumann and Robin always capitalized.

@gforsyth can you help us out with the conflict? GitHub can't automatically merge.

siddarth407 commented 9 years ago

hello professor, Thanks for the response, I will make changes and upload it soon.

siddarth407 commented 9 years ago

Professor, My notebook follows closely with module 4, Lesson4. I have indicated the link to the module in my notebook. In the beginning i have already mentioned that i will be doing the problem with different boundary conditions. Since the equations for robin boundary condition were different i had to write all the equations.

I will re-organize the notebook and make the changes you mentioned and upload the notebook soon. Thank you

labarba commented 9 years ago

Oh, all that I'm suggesting is now optional. You don't have to make changes unless you wish to, for making a better contribution to the "knowledge base" of this course.