Adding Project by Akash Dhruv

[labarba]

As expected, Akash, a top-notch contribution to the numerical-methods-with-Python ecosystem.

Your code works nicely, and as you know, getting the right answer always comes before getting the right answer fast. But a few optimizations come to mind when reviewing your code. When you form your grid, for example, you have double loops—can you think of any method to replace those index manipulations and double loops?

Very nice illustration of the staggered grid! (newgrid.png)

You are using a triple loop for the pressure Poisson solver—again, this will work, but will be slow. Can you think of ways of replacing the triple loop.

Basically, whenever you are using index manipulations in Python, you should ask yourself if you can do it another way. Index manipulations are very slow in Python.

RK methods are called "multi-step methods" and this is different from fractional step. What you are doing, with a predictor step and a projection via the pressure Poisson equation is, in fact, a fractional step method.

Typos

• "Navier-Stokes" should be capitalized, as the names belong to people, Mr. Navier, and Mr. Stokes. And I think you should move the equations up to where they are first mentioned, just before "Introduced in 1822…" (and you did not define \rho)
• fulid —> fluid
• "correct analytical solution" —> I think you mean "exact" (or maybe just say "general"?)
• pratical —> practical
• greately —> greatly
• compound adjectives should be hyphenated: cost-effective design
• soultion –> solution
• Cartesian should be capitalized
• substituion —> substitution
• Taylor should be capitalized
• experession —> expression
• Poisson should be capitalized
• fracitonal —> fractional
• girds —> grids
• apporaches —> approaches
• "points inside the body are determined using it's equation"—> should be "their equation" for the plural, but in the singular you'd not use the apostrophe: It's not Its.
• "both and u and v velocity" —> both u and v velocity

Style

• The paragraph starting "This notebook will …" is very long. Try breaking it down (add paragraph break where you move to a new idea.)
• Your code is a little bit dense. Try adding a space before and after equal signs, for example.
• "Post processing, data visualization and validation" —> turn that into a heading title

Other

• … moving boundaries (rotating cylinder): you are talking about moving boundaries that benefit from IBM, so the rotating cylinder is not a great example, as it does not involve grid re-generation.

I'm happy to merge this PR as is, and leave it up to you if you want to later on correct typos. You can then issue a new PR.

Great work in this course!

[akashdhruv]

Professor,

Thank you for the review. I was waiting for it since a long time. I will surely correct the typos and will try to incorporate all of your suggestions.

Happy Holidays

Regards, Akash

[labarba]

Sorry for the wait, Akash! The development to add a badging solution within Open edX was a lot more effort than I could've imagined. That was a big time sink for me and I got behind in lots of things. But you submitted really early, too!

[akashdhruv]

I understand professor. No problem.