numerique-gouv / meet

MIT License
8 stars 0 forks source link

Participant get disconnected #144

Closed lebaudantoine closed 1 month ago

lebaudantoine commented 2 months ago

Bug Report

Problematic Behavior Participants who are already in a room get disconnected unexpectedly.

Affected users include @rouja, @sampaccoud, and r. squelbut.

Additional details from r. squelbut:

For example, @rouja experienced a disconnection approximately 30 minutes into a meeting.

Expected Behavior/Code Participants should remain connected to the room once they have joined.

Steps to Reproduce Reproducing the bug is challenging. Currently, efforts are underway to establish a reliable setup to consistently replicate the issue.

lebaudantoine commented 2 months ago

I've started some investigations under this PR https://github.com/numerique-gouv/meet/pull/145

It might be related to how the client get, manipulate and refresh the room's data, which contains the access token. I know that react-query refresh stale data when window's focus change (if the query is enabled).

Recent's changes have been made to consider the room data stale after 6 hours. But I am not totally sure on how the LiveKitRoom component will re-render if its token props change. (Please see sources)

lebaudantoine commented 2 months ago

Should we avoid setting connect to true when the token might be undefined?

token={data?.livekit?.token}
connect={true}