numerique-gouv / meet

MIT License
10 stars 0 forks source link

Enhance pre-join #46

Open lebaudantoine opened 4 months ago

lebaudantoine commented 4 months ago

Feature Request

Is your feature request related to a problem or unsupported use case? Please describe.

We currently use the default Pre-join component from LiveKit, which, while convenient, has several drawbacks in terms of UX and accessibility.

First, the dropdown menu serves two purposes: enabling/disabling data and selecting the data source. This dual functionality can be confusing for users.

Second, the layout of this page needs improvement for a better user experience.

Lastly, we should consider whether to add a pre-join screen when creating a new meeting. If users have a preferred configuration saved, we might want to skip this screen when they create a meeting.

I've designed a pre-join mockup, inspired by Google's interface. Let me know what you think.

Please refer to the mockup page in the figma file

Capture d’écran 2024-07-18 à 22 09 34

lebaudantoine commented 4 months ago

@rouja shares the same feedbacks, it's quite frustrating having a pre-join screen when you just create a meeting.

lebaudantoine commented 3 months ago

PR opened by @manuhabitela #106. Still draft, I've started merging some parts.

lebaudantoine commented 1 week ago

Additional Feedback:

  1. Pre-join Enhancement: Add a background blur toggle button before entering the room (similar to GMeet's implementation)

Image

  1. Layout Issue: The horizontal layout poses problems for agents with low-resolution public screens: some users can't even see the join button due to their screen constraints.

Image

  1. Make sure can select their appropriate Audio / Video input and Audio output. We should work for all OS and all browser, It's not the case, I fucked up the code, it works on my machine, but not on all machines.
lebaudantoine commented 1 week ago

It's an opportunity to investigate issue #212. As we would reuse the same piece of code for input/output selection. I used the default hook from LiveKit here. Let's discuss it IRL.

lebaudantoine commented 1 week ago

Pre-join screen will automatically populate usernames using ProConnect full names once backend serialization (issue #206) is completed.

lebaudantoine commented 14 hours ago

Enable mic testing, to make sure your mic is working