search

numerique-gouv / people

Teams management application
MIT License
13 stars 1 forks source link

Improve front-end caching #494

Closed Morendil closed 3 weeks ago

Morendil commented 3 weeks ago

Purpose

Caching was ineffective on E2E setup, this simplifies caching logic and will hopefully speed up the E2E testing part of the build.

Proposal

Take advantage of the built-in caching directive in newer versions of the Node setup action.

Morendil commented 3 weeks ago

Closing this version because looking at the time where time is actually spent show that I was not going in the right direction. What's taking a long time is not the yarn install part but the playwright install part. These are system dependencies not Node dependencies… Also the caching system in actions/setup-node is substantially (and confusingly) different from actions/cache.

Morendil commented 3 weeks ago

In addition, this bit of bad news is kind of putting me off the idea of caching this particular step at all…