search

numerique-gouv / people

Teams management application
MIT License
13 stars 1 forks source link

⬆️(dependencies) remove unneeded dependencies #503

Closed Morendil closed 2 weeks ago

Morendil commented 2 weeks ago

Purpose

To reduce attack surface and dependency updates, remove listed dependencies that are not actually in use.

Proposal

Remove url-normalize which is not referenced anywhere

qbey commented 2 weeks ago

boto3 is used by django-storages with S3 Brotli is used by whitenoise url-normalize seems indeed not used anywhere :)

Morendil commented 2 weeks ago

To recap our quick in-person chat: for django-storages and whitenoise respectively, boto3 and Brotli are transitive dependencies but marked as optional, so we're leaving them in to ensure they're both picked up.