search

numero2 / contao-storelocator

Contao Plugin for managing stores (or in common address data) and providing a frontend-search based on geo data.
https://www.numero2.de/contao/erweiterungen/storelocator.html
GNU Lesser General Public License v3.0
13 stars 8 forks source link

Template selection fails #35

Closed asaage closed 4 years ago

asaage commented 5 years ago

Contao-version 4.8.3 It's not possible to create any storelocator modules

Argument 2 passed to Contao\Controller::getTemplateGroup() must be of the type array, string given

The getTemplateGroup function changed -> https://github.com/contao/contao/commit/bdc4dd86ff5209bc03a6fbc009e0b6f1c601834f

It's called here -> https://github.com/numero2/contao-storelocator/blob/master/dca/tl_module.php#L421

bennyborn commented 5 years ago

Seems to me that the second parameter was a leftover from Contao 3. Looking at the 4.4 branch there seems to be no second parameter at all:

https://github.com/contao/core-bundle/blob/4.4/src/Resources/contao/library/Contao/Controller.php#L93

The second parameter in 4.8 being optional I guess we're good just to strip it entirely?

asaage commented 5 years ago

If i do that only two templates are available and they are not appropriate to the module-type.

Like here for the Händlersuche:

image