numirias / paxmod

🕊️ Firefox add-on for multi-row tabs and site-dependent tab colors
MIT License
247 stars 15 forks source link

Tab compression #46

Closed jtagcat closed 4 years ago

jtagcat commented 4 years ago

image I'd expect a new row to be made, when normally firefox would display the tab scrolling arrow, currently all tabs could be fit on one row. 1) Make the tabs smaller until a set minimum of a tab's width (compression) Screenshot from 2019-12-03 17-28-19 1) When firefox normally shows you the tab scrolling arrows, then go to a new row instead. Screenshot from 2019-12-03 17-28-33 1) illustrating expected behaviour: image

Related: #44 (but essentially the opposite of this issue)

Delta2401 commented 4 years ago

I have noticed a way to shrink my tabs to the size they were before. After about a week, I realized it simply didn't rename the tabs to a shorter version, or any cutoff anymore; as the bug. Which is why when I restore some sessions, at least for a brief moment, it can all be small; or default view, something loads that changes the tab sizes due to the name. And really long table titles, like a twitter one, were taking up an entire tab row by themselves, and 4 open in new tabs was 4 new rows down [put easily into 1 row again below].

This led to my downloading of my Tab Mix - Rename Tab extension, to rename all the tabs to shorter, succinct tab titles. Sure enough, I got them all smaller, for all rows. More or less the amount of tab rows I had several weeks back; the only downside is they aren't in uniform sizes, where you can plot your close tab X, when closing multiple tabs. Another I noticed; is that the bottom row will always make the tabs stretch to fit no matter what, if you only have 3 tabs in your bottom row, then it will be 3 large tabs no matter what; but you can keep fitting in new ones until they are all much smaller. I use the Tab Mix - Rename Tab, because you can lock the tab of yours to that tab no matter URL, etc. So for the tabs I keep open and almost never change, they will be there; saved session for session, etc.

Right now, I am happy enough with this effect; as it is more or less, almost as functional in multirow tabs as before.

A way to fix this extension, I think would be to create an extension that renames all tabs to the proper amount of spaces you put in/ cropping off the extra; to make a more uniformed tab size. Or just not care about specific tab sizes, and just not have extra spaces; idk - depends on preference.

Here is my pic, of what just 5 days ago was like 10 annoying rows of firefox, simply from using Tab Mix - Rename Tab:

1Fix

And my other PC: 2

jtagcat commented 4 years ago

Renaming is not dynamic (unless you really want to make it) - all tabs are always the same size, what is still the same bad for me. Also by renaming, you can't hover on the tab to get it's full name.

Delta2401 commented 4 years ago

Well, between not having dynamic tabs, and being able to hover for full name, and having 50 rows of tabs for no reason; I think it's still the best option so far; I hope we get a fix. Also, if you use a good name shortening convention, where you know what it is as your name it to it, you should be able to not need a full name hover, no?

numirias commented 4 years ago

I'm assuming the tab shrinking issue relates to #47 which is now fixed. If not, feel free to reopen.

jtagcat commented 4 years ago

Referring to the settings of the extension: Max. tab width has been indeed fixed. (you can now set tab size for tabs statically (not dynamically). Min. tab width (what I'm the most after) is still broken. (tabs are pretty much always the same size currently) As such, I'd reopen this issue, but for some reason (probably GH Repository settings prevent me), I can't. @numirias

numirias commented 4 years ago

@jtagcat The settings work for me. You might be misunderstanding the tab resizing logic: A tab takes Default tab width percent of the space in a row, but at least Min. tab width pixels, and at most Max. tab width pixels.

If you set default to 0%, your tabs will each take max pixels and shrink to min pixels, before a new line is created. Or in other words, default: 10% means you want 10 tabs per row, 0% means you allow an infinite amount of tabs per row within the bounds of min and max.

jtagcat commented 4 years ago

Makes more sense now.. ..but it should be clarified somehow.