search

numirias / pytest-json-report

🗒️ A pytest plugin to report test results as JSON
MIT License
147 stars 39 forks source link

accomodate missing _json_report_extra for issue 75 #76

Closed dchudz closed 2 years ago

dchudz commented 2 years ago

I think this fixes https://github.com/numirias/pytest-json-report/issues/75.

(Maybe there's a better way to fix it though - not sure.)

Note that I confirmed the new test fails before the fix.

mrocklin commented 2 years ago

I'll admit to not understanding the implementation, but the test looks solid to me.

mrocklin commented 2 years ago

Hrm, it looks like the most recent PR to this repository has gone untouched for a few weeks. It seems like this repository may be infrequently maintained.

@numirias is there anything we can do to reduce maintainer burden on you? Our alternative would be to fork this off privately.

dchudz commented 2 years ago

thanks @numirias !

numirias commented 2 years ago

Thanks for the great bug report and PR @dchudz.

And sorry for not merging earlier. I'll be more responsive regarding straightforward bug fixes like this one.

dchudz commented 2 years ago

Thanks! No worries -- I appreciate the package, and appreciate getting the fix released.