search

numirias / semshi

🌈 Semantic Highlighting for Python in Neovim
1.03k stars 34 forks source link

Add an error handling of event_text_changed() #106

Closed sh8 closed 3 years ago

sh8 commented 3 years ago

Fix this error by adding a None check for self._cur_handler. https://github.com/numirias/semshi/issues/105

alexcg1 commented 3 years ago

Is there any easy way to use your fork with Vim-Plug @sh8 ? Seems semshi hasn't had any updates for a long while so not expecting your PR to be merged any time soon

blueyed commented 3 years ago

Thanks for addressing this.

It should probably have a comment / updated doc there: currently it looks like the existing comment might refer to the newly added code. Might make sense to turn it into a docstring, and then add a new comment with the new code.

sh8 commented 3 years ago

Is there any easy way to use your fork with Vim-Plug @sh8 ? Seems semshi hasn't had any updates for a long while so not expecting your PR to be merged any time soon

You can install the forked one like this;

Plug 'sh8/semshi', {'do': ':UpdateRemotePlugins'}
sh8 commented 3 years ago

Thanks for addressing this.

It should probably have a comment / updated doc there: currently it looks like the existing comment might refer to the newly added code. Might make sense to turn it into a docstring, and then add a new comment with the new code.

Thank you for pointing it out!