handler: _update_step: remove calling of `mark_selected`

numirias / semshi

🌈 Semantic Highlighting for Python in Neovim

1.03k stars 34 forks source link

handler: _update_step: remove calling of `mark_selected` #94

Open blueyed opened 4 years ago

blueyed commented 4 years ago

This should not be necessary in general, since it gets triggered via CursorMoved already. It also might trigger an error due to self._vim.current.window not being a valid window anymore, when cursor gets accessed [1]. It also should not be using the global current window's cursor (which might be for another buffer!) to mark selected nodes in the buffer.

1: https://github.com/numirias/semshi/issues/72

petobens commented 3 years ago

I've been using this for a while now and it seems to fix the issue described in #72 . Thanks @blueyed :)

petobens commented 3 years ago

@numirias can you merge this? I've been using it for over a month without problems.