numist / Switch

A window-based context switcher for the Mac
157 stars 17 forks source link

Event tap should treat suppression of key events as a subscription. #109

Closed numist closed 3 years ago

numist commented 9 years ago

@property (nonatomic, assign, readwrite) BOOL suppressKeyEvents; should be - (void)observer:(id)observer wantsSuppressKeyEvents:(_Bool)suppressKeyEvents;

Using a boolean for this seemed like a good idea at the time, but if two actors ever want to suppress key events they'll clobber each other. A subscription model with the event tap managing the actual binary state of suppression is a better approach.

numist commented 3 years ago

Fixed in #139