Use AutoLayout in SWHUDCollectionView

numist / Switch

A window-based context switcher for the Mac

157 stars 16 forks source link

Use AutoLayout in SWHUDCollectionView #78

Closed numist closed 10 years ago

numist commented 10 years ago

i-have-no-idea-what-im-doing-dog

It would be awesome if someone could have a look at SWHUDCollectionView's implementation of updateConstraints.

This is part 2 of #63.

numist commented 10 years ago

It would also be awesome if RAC passed unit tests on Travis on this branch like it does on develop. The submodule has the same SHA on both branches! What gives?

robrix commented 10 years ago

I think you could get some more mileage out of min/max constraints
remember that you can also add constraints outside of -updateConstraints

Otherwise seems pretty reasonable. I bet @kongtomorrow could tell you more tho :smile:

numist commented 10 years ago

Thanks for the review! Especially good point about conservatively updating constraints when moving the selection box and factoring common layout tasks.

robrix commented 10 years ago

Glad I could help!

numist commented 10 years ago

Ok, I think that's everything! On to the next stage.