search

numixproject / elegance-colors

A highly customizable chameleon theme for Gnome Shell
117 stars 7 forks source link

Dash to Dock compatibility #29

Open sojusnik opened 10 years ago

sojusnik commented 10 years ago

Hi Satya!

Thanks for your effort making the Linux experience a little more polished and user-friendly!

Your wonderful Numix Gnome-Shell theme could be even better, if this theme was compatible with the Gnome Extension called "Dash to Dock"¹. Some themes already support it², since it's actually quite easy to achieve³.

Would be great, to see this implemented soon!

¹ https://extensions.gnome.org/extension/307/dash-to-dock/ and https://github.com/micheleg/dash-to-dock ² http://micheleg.github.io/dash-to-dock/themes.html ³ http://micheleg.github.io/dash-to-dock/theming.html

satya164 commented 10 years ago

Hi. Last time I tried, extensions didn't support custom theming. I'll try again.

sojusnik commented 10 years ago

Thanks!

sojusnik commented 10 years ago

Please let me know, if you've made some progress on this. Can't wait to test this out.

sojusnik commented 10 years ago

There's a new version¹ out with an option to apply a custom theme (the customized Adwaita theme), but, imho, it looks a little bit out of place with the numix version, because the reddish underlining is still there². It would be really nice, if the dots would be a little bit bigger and have the color of the underlining, that should be removed. Is this currently possible?

¹ https://micheleg.github.io/dash-to-dock/news/index.html ² http://i.imgur.com/pNk7A3y.png

satya164 commented 10 years ago

I wonder why the dev doesn't reuse the styles from the default dash, as it'll allow user themes to style it. I think its silly that we theme devs will need to support specific extensions, whereas the extension dev could have supported all user themes.

Check our dock extension https://github.com/ozonos/atom-dock if that could fill your need. Right now I don't have much time to do this.

BTW Atom Dock appears on bottom, and not left side, also it's still in developement, so has some bugs.

micheleg commented 10 years ago

Hello, I'm the developer of the dash-to-dock extension. Would you mind elaborating how it is preventing the application of custom themes? As explained in the pages linked above, I tried since the early versions to be theme-agnostic as much as possible, also developing a very simple custom theme. Let me know if I'm missing something or doing it wrong.

satya164 commented 10 years ago

@micheleg Hi. I hadn't really tried the extension with Gnome 3.12. I tried now and I see there is no issue here. May be the issue with @sojusnik is that he has the "Apply custom theme" option checked?

Sorry to bother you :(

micheleg commented 10 years ago

With that option that I've recently introduced (both to 3.12 and 3.10) to avoid distributing a separate theme that was actually just a couple of minor tweaks I'm actually overwriting the theme settings, but I state in the option that it's meant for Adwaita. As it's on by default, maybe I should document better the thing.

In any case, if you have ideas on how to implement better theming support, for instance adding further custom classes, let me know.

satya164 commented 10 years ago

@micheleg Hmm.. may be you can check if the theme is Adwaita and only then enable it? Is it possible?

satya164 commented 10 years ago

@micheleg Also, I would avoid adding custom classes as themes will need to add styles to support the extension.

micheleg commented 10 years ago

Yes, I suppose it's possible to get the theme and disable the option in case it's not adwaita.

Regarding custom classes: as far as I know there is no way I can allow a theme developer to customize for instance the dots for running application if not by providing a custom class for it.

The idea is that if those are ignored, still all the style of the default dash are applied. So the extension is always integrated with the theme for the basic styles. Some advance customization instead depends on the theme targeting the extension. I thought this was a good compromise.

satya164 commented 10 years ago

@micheleg The running applications thing, that's how you style it. But different themes already have different styles for running apps. So the thing is, should you really worry about that?

micheleg commented 10 years ago

What I added is the ability to apply different style for different number of windows that is not provided by the upstream dash. The default .running class is there, but I added the .running1 .running2 etc classes, which can obviously be ignored. But if a theme wants to take advantage of them, they are there. Since I changed the behaviour of the click, that is one cycle through the app windows it's quite handy to have an idea of the number such windows.

Similarly, there is the .extended class, in case one want to tweak the appearance in this mode, for instance removing the rounded borders. The .dashtodock class allows for instance to change the background opacity for the dock dash living also outside the overview.

These are meant as additional features not interfering at all with all default behaviour and I thought they were useful to me and potentially interesting for theme developers.

satya164 commented 10 years ago

@micheleg Yeah, these are understandable, and you cannot do anything better here anyways :D

Cheers for caring so much about third party themes. Many devs don't do that :(

sojusnik commented 9 years ago

Hey Satya!

Is there still a chance, that the Numix Gnome Shell will be compatible with Dash to Dock?

satya164 commented 9 years ago

@sojusnik I would love to add support. But I'm very much busy :(

Patches are more than welcome.

sojusnik commented 9 years ago

Don't worry! Take your time and thanks for Numix and your other wonderful projects!

micheleg commented 9 years ago

Just an update: in the latest versions of dash-to-dock the built-in theme is disabled by default and it's optionally split in three parts: size shrinking, background customization and windows counter dots. Still not perfect with all themes, but this is the best that can be done on my side.

sojusnik commented 9 years ago

Looks very promising, thanks!

satya164 commented 9 years ago

Thanks. Will have a look.

On Sat, Jan 17, 2015, 5:19 PM sojusnik notifications@github.com wrote:

Looks very promising, thanks!

— Reply to this email directly or view it on GitHub https://github.com/satya164/elegance-colors/issues/29#issuecomment-70364201 .

sojusnik commented 9 years ago

The new version of Dash to Dock changed, among other things, the color of the dots, so that the Numix theme currently looks the following way. IMHO, the most elegant solution would be now, that the dot(s) of the active application should be colored in the typical Numix reddish/orange color, while the other dots should remain gray. All other current indicators like the orange underlining and the indentation of the icon of the active application could be easily removed.

vantu5z commented 9 years ago

Have some issue with corners artifacts, opened in micheleg/dash-to-dock (162). When change shell theme - all is fine.