numixproject / numix-core

Builder for App Icon Themes
GNU General Public License v3.0
766 stars 146 forks source link

Icon request for: League of Legends #1086

Closed magamig closed 9 years ago

magamig commented 10 years ago

An icon for LOL (League of Legends) is missing. I run it with WINE.

--- Want to back this issue? **[Place a bounty on it!](https://www.bountysource.com/issues/3795677-icon-request-for-league-of-legends?utm_campaign=plugin&utm_content=tracker%2F514195&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F514195&utm_medium=issues&utm_source=github).
Foggalong commented 10 years ago

We generally don't fix WINE applications unless it's a popular request. For now tagged as wontfix but is some more people reqest it (by commenting +1 here) then we'll do it.

PTNobel commented 10 years ago

+1 (I think this is what Joshua meant)

Foggalong commented 10 years ago

It is :)

pamarsan commented 10 years ago

+1 too :) It works really well with playonlinux and looks so ugly like this :S captura de pantalla de 2014-09-18 10 32 27

magamig commented 10 years ago

I think that is enough "+1", so are you going to do it?

Foggalong commented 10 years ago

Currently only 3. If it gets to 5 we'll turn it into a normal request. If we opened to the doors to every application possible to run through WINE it would increase our workload tenfold.

sergioad commented 10 years ago

I do not use Wine apps but I will help this request, BTW a blue Numix circle icon with a white L can be good, obviusly with the same typography of the original icon

doodoong commented 9 years ago

+1

magamig commented 9 years ago

@Foggalong Yeah, we got 5, can you do it now?

Foggalong commented 9 years ago

Out of curiosity what's the icon line in the launcher?

magamig commented 9 years ago

what do you mean? you want me to post the current icon?

On 5 October 2014 16:01, Joshua Fogg notifications@github.com wrote:

Out of curiosity what's the icon line in the launcher?

— Reply to this email directly or view it on GitHub https://github.com/numixproject/numix-icon-theme-circle/issues/1086#issuecomment-57938628 .

cesasol commented 9 years ago

+1 We need to use special methods to have the game in our teams so "LeagueofLegends.png" would be the ideal file name.

In the file system of the game the icon is lol.png lol.ico

Foggalong commented 9 years ago

In the .desktop file for the game, what does the line beginning Icon= say? See the readme of you're still stuck

pamarsan commented 9 years ago

Yeah, he means the line "icon=" that you see if you open the .desktop file with gedit or any other text editor. The .desktop file is probably in .local/share/applications if you installed it through playonlinux

magamig commented 9 years ago

The mane is "playonlinux-League of Legends.desktop"

On 5 October 2014 23:07, pamarsan notifications@github.com wrote:

Yeah, he means the line "icon=" that you see if you open the .desktop file with gedit or any other text editor. The .desktop file is probably in .local/share/applications if you installed it through playonlinux

— Reply to this email directly or view it on GitHub https://github.com/numixproject/numix-icon-theme-circle/issues/1086#issuecomment-57954253 .

magamig commented 9 years ago

*name I think that is the one :)

On 6 October 2014 15:12, Miguel Magalhaes magamig@gmail.com wrote:

The mane is "playonlinux-League of Legends.desktop"

On 5 October 2014 23:07, pamarsan notifications@github.com wrote:

Yeah, he means the line "icon=" that you see if you open the .desktop file with gedit or any other text editor. The .desktop file is probably in .local/share/applications if you installed it through playonlinux

— Reply to this email directly or view it on GitHub https://github.com/numixproject/numix-icon-theme-circle/issues/1086#issuecomment-57954253 .

Foggalong commented 9 years ago

That's not the icon line, that's the launcher path

pamarsan commented 9 years ago

Now open gedit and drag that .desktop file into it. And see what "Icon=" line says

magamig commented 9 years ago

"Icon=/home/magamig/.PlayOnLinux//icones/full_size/League of Legends"

On 6 October 2014 15:52, pamarsan notifications@github.com wrote:

Now open gedit and drag that .desktop file into it. And see what "Icon=" line says

— Reply to this email directly or view it on GitHub https://github.com/numixproject/numix-icon-theme-circle/issues/1086#issuecomment-58028655 .

magamig commented 9 years ago

Here is the full file:

"[Desktop Entry] Encoding=UTF-8 Name=League of Legends Comment=PlayOnLinux Type=Application Exec=/usr/share/playonlinux/playonlinux --run "League of Legends" %F Icon=/home/magamig/.PlayOnLinux//icones/full_size/League of Legends Name[fr_FR]=League of Legends StartupWMClass=lol.launcher.admin.exe Categories=Game;RolePlaying;"

On 6 October 2014 15:56, Miguel Magalhaes magamig@gmail.com wrote:

"Icon=/home/magamig/.PlayOnLinux//icones/full_size/League of Legends"

On 6 October 2014 15:52, pamarsan notifications@github.com wrote:

Now open gedit and drag that .desktop file into it. And see what "Icon=" line says

— Reply to this email directly or view it on GitHub https://github.com/numixproject/numix-icon-theme-circle/issues/1086#issuecomment-58028655 .

Foggalong commented 9 years ago

Thanks :)

sergioad commented 9 years ago

@Foggalong you have a lot of work untill you release the next icons update it not it? hahahahaha oh well I hope see the update soon :) BTW is some way to solve the issue #1190 manually?

bilelmoussaoui commented 9 years ago

+1

bilelmoussaoui commented 9 years ago

@ChuckDaniels87 would you take a look at this?

ismaelgv commented 9 years ago

That game stole a lot of my lifetime, I suppose it deserves its own icon. :stuck_out_tongue_closed_eyes:

bilelmoussaoui commented 9 years ago

i would be so happy if you give it a try ::D

ismaelgv commented 9 years ago

Merged, close it.