Open skyghis opened 8 years ago
We still need all the actual icon names to be able to fix the issue. The developer in the issue referenced mentions that the icons now follow a format, but without a list of names we still can't fix this.
This was fixed upstream, you can take a look at the issue reported on nuvola's repo
Le 14 sept. 2016 12:33, "Joshua H. Fogg" notifications@github.com a écrit :
Closed #3423 https://github.com/numixproject/circle-core/issues/3423.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/numixproject/circle-core/issues/3423#event-788924322, or mute the thread https://github.com/notifications/unsubscribe-auth/AHTlxX2dP8rzWz2FbxtSu8srIzljUlpRks5qp81zgaJpZM4J8hI1 .
@bil-elmoussaoui See above comment. It's not that they're hardcoded, it's that we don't have the names.
@Foggalong The icons names are in hicolor theme. The exhaustive list in screenshot:
Do you want me to create a separate issue per icon ?
No, here's fine. I've created a list in the original issue body so we can utilise GitHub's todo functionality. Thanks for adding the details needed :)
Last time I checked this all launchers I didn't commit icons for were still hardcoded.
I see the issue #1576 closed. great you find a way to support Nuvolaplayer integration scripts icons. It would be great if all integration scripts have an icon.
Current status :
I'm personally interested by the PlexMusic icon :innocent: