Closed Foggalong closed 4 years ago
Some more small issues:
I'm not sure what you mean about point 1?
Oops, I thought the list wasn't complete but given that 2290 is the number of icons in Circle it surely is.
Noticed something while reviewing PRs: When this is closed we're probably not finished. There are some icons which didn't nned fixing in Circle but use masking/clipping in Square. Viewing the Square files in a Qt viewer (Nomacs, Gwenview) will reveal this.
@palob Do you know if the GitHub file previewer is still a reliable indicator of this too or has it been fixed?
Haven't checked in a while but the GitHub brokenness was definitely visually different to the Qt one.
First of all, great work! And thanks for making it free.
I hope this is okay to write here, but one thing I'd love to see is a Thunderbird icon that's similar to the Firefox one. The current one is good, but when looking at you don't really know that it's Thunderbird.
Here's a great Material themed thunderbird icon (not square, and I assume, non-free though): https://icons8.com/icon/38697/thunderbird
@CreamyCookie Just to copy across the response from the original issue for others:
We already have one, going by the icon name
thunderbird-branded.svg
, it's just not the default for Thunderbird because it's not as nice an icon as the unbranded version. In the same vein we havefirefox-icon-unbranded.svg
found here which isn't the default for the same reason.
@Foggalong True, that one isn't very pretty. I'd love an icon in a similar vein to the Firefox one. More space-filling, beautiful and branded, so one immediately recognizes Thunderbird.
@CreamyCookie Yeah, it could probably do with an update. Will make a new issue for that for you since this one is specially about sorting out inconsistencies within the Square theme from Circle
This list needs to be updated with the ones from #3481.
@palob are you sure about this? i have updated the list on #3481 to keep track of what's still need to be done as it was getting my laptop lagging whenever i tried to mark an icon as fixed
All icons done by @W-Floyd are on par with Circle and can be checked here.
@palob We should then just list the icons from the old Square icon theme
As requested in #4041, icons most obviously out of agreement are as follows:
Some of these may have acceptable differences in symbol design between circle/square, but it's a decent guide all the same.
I'll be working on this this weekend.
@W-Floyd You took care of all the calendar icons, right?
And IIRC of the Firefox icons as well?
Yes, the calendar icons should be good, though I might PR a final set of changes on them, since #4120 is in. Edit: See #4141
Firefox... I think I did? I dunno, it was a while back, as part of the square porting spree.
I'd like to help out on this, if we could work out who can do what.
Also, to clarify for myself, signed commits are allowed here now, right?
If any body wants to chime in, what needs to be done is:
For full-baseplate designs more reworking is required.
I will start the list from top, going down alphabetically. So other people could go bottom up or centre-up/down.
@W-Floyd Yeah, allowed since the PPA doesn't build from here anymore.
So, basically re-porting all existing square icons, minus the ones I did?
Exactly, but there a still some of your ported icons unchecked which didn't exist in Square before. Basically any single Square icon which you didn't port and existed before isn't up to scratch and needs to be updated from Circle.
Okay.
If we can parse out a list for that, I have a script pretty much set up with devilspie2
that helps open and tile inkscape windows split-screen automatically, then add and commit the files.
A graphical automation for the entire process?
Ha ha, I wish... Just helps manage opening the files in Inkscape like this.
Interestingly enough your list adds some to the list above.
Some false positives.
Yeah, some of them might just be acceptable variations in symbol design.
The script I'll be using, if anyone wants a peek, lives here.
We should probably skip the steam ones and do them later. Most of them got renamed.
Turns out almost none of the icons made for #3481 is ticked off here.
I'm currently not proceeding alphabetically but rather fixing the most obviously broken ones first.
Another way of seeing whether or not a Square icon has been updated yet is comparing file sizes. If on par (and carrying the same symbol design ofc) the Square icon should be a smaller file than the Circle icon.
Active clippings will become obvious when viewed in a Qt viewer (Gwenview, Nomacs).
Here's a list of icons that should be updated too https://pastebin.com/raw/fGJF1Eh8 The list contains the icons that still has a one-line SVG (old optimization options)
I'm going to write a test that verifies every icon if it does follow the optimization options :) which will gives the real list :p
I hope it will. Since it does not verify visual insufficiencies there might be outdated designs with correct optimisation.
With my latest PRs merged I think this can be safely closed. If there are any issues left those will only be about lacking optimisation/bigger than neccessary filesize. Whenever I stumble upon something I'm going to fix it.
What's left is the redesign of the jetbrains icons (which depends on the outcome of #3706), should be tracked individually.
Agree with that call :+1:
Of the icons already covered in Square, not all of them have been properly checked over. This includes:
This will be done as new icons are covered for #3481 but the existing ones need going over too, which is what the list below covers.
* [ ] chrome-gcjbnclfkeffmdfdhflnadahgmajfgcm-Default