search

numixproject / numix-core

Builder for App Icon Themes
GNU General Public License v3.0
765 stars 146 forks source link

Optimisation & Design Updates for Square #3482

Closed Foggalong closed 4 years ago

Foggalong commented 7 years ago

Of the icons already covered in Square, not all of them have been properly checked over. This includes:

  1. Have the latest Numix design (the one used by Circle)
  2. Be void of clipping, strokes, and other elements which cause problems
  3. Be saved as an Optimised SVG

This will be done as new icons are covered for #3481 but the existing ones need going over too, which is what the list below covers.

palob commented 7 years ago

Some more small issues:

Foggalong commented 7 years ago

I'm not sure what you mean about point 1?

palob commented 7 years ago

Oops, I thought the list wasn't complete but given that 2290 is the number of icons in Circle it surely is.

palob commented 7 years ago

Noticed something while reviewing PRs: When this is closed we're probably not finished. There are some icons which didn't nned fixing in Circle but use masking/clipping in Square. Viewing the Square files in a Qt viewer (Nomacs, Gwenview) will reveal this.

Foggalong commented 7 years ago

@palob Do you know if the GitHub file previewer is still a reliable indicator of this too or has it been fixed?

palob commented 7 years ago

Haven't checked in a while but the GitHub brokenness was definitely visually different to the Qt one.

CreamyCookie commented 7 years ago

First of all, great work! And thanks for making it free.

I hope this is okay to write here, but one thing I'd love to see is a Thunderbird icon that's similar to the Firefox one. The current one is good, but when looking at you don't really know that it's Thunderbird.

Here's a great Material themed thunderbird icon (not square, and I assume, non-free though): https://icons8.com/icon/38697/thunderbird

Foggalong commented 7 years ago

@CreamyCookie Just to copy across the response from the original issue for others:

We already have one, going by the icon name thunderbird-branded.svg, it's just not the default for Thunderbird because it's not as nice an icon as the unbranded version. In the same vein we have firefox-icon-unbranded.svg found here which isn't the default for the same reason.

CreamyCookie commented 7 years ago

@Foggalong True, that one isn't very pretty. I'd love an icon in a similar vein to the Firefox one. More space-filling, beautiful and branded, so one immediately recognizes Thunderbird.

Foggalong commented 7 years ago

@CreamyCookie Yeah, it could probably do with an update. Will make a new issue for that for you since this one is specially about sorting out inconsistencies within the Square theme from Circle

palob commented 7 years ago

This list needs to be updated with the ones from #3481.

bilelmoussaoui commented 7 years ago

@palob are you sure about this? i have updated the list on #3481 to keep track of what's still need to be done as it was getting my laptop lagging whenever i tried to mark an icon as fixed

palob commented 7 years ago

All icons done by @W-Floyd are on par with Circle and can be checked here.

bilelmoussaoui commented 7 years ago

@palob We should then just list the icons from the old Square icon theme

W-Floyd commented 6 years ago

As requested in #4041, icons most obviously out of agreement are as follows:

Some of these may have acceptable differences in symbol design between circle/square, but it's a decent guide all the same.

palob commented 6 years ago

I'll be working on this this weekend.

palob commented 6 years ago

@W-Floyd You took care of all the calendar icons, right?

And IIRC of the Firefox icons as well?

W-Floyd commented 6 years ago

Yes, the calendar icons should be good, though I might PR a final set of changes on them, since #4120 is in. Edit: See #4141

Firefox... I think I did? I dunno, it was a while back, as part of the square porting spree.

I'd like to help out on this, if we could work out who can do what.

Also, to clarify for myself, signed commits are allowed here now, right?

palob commented 6 years ago

If any body wants to chime in, what needs to be done is:

For full-baseplate designs more reworking is required.

I will start the list from top, going down alphabetically. So other people could go bottom up or centre-up/down.

@W-Floyd Yeah, allowed since the PPA doesn't build from here anymore.

W-Floyd commented 6 years ago

So, basically re-porting all existing square icons, minus the ones I did?

palob commented 6 years ago

Exactly, but there a still some of your ported icons unchecked which didn't exist in Square before. Basically any single Square icon which you didn't port and existed before isn't up to scratch and needs to be updated from Circle.

W-Floyd commented 6 years ago

Okay.

If we can parse out a list for that, I have a script pretty much set up with devilspie2 that helps open and tile inkscape windows split-screen automatically, then add and commit the files.

palob commented 6 years ago

A graphical automation for the entire process?

W-Floyd commented 6 years ago

Ha ha, I wish... Just helps manage opening the files in Inkscape like this.

palob commented 6 years ago

Interestingly enough your list adds some to the list above.

Some false positives.

W-Floyd commented 6 years ago

Yeah, some of them might just be acceptable variations in symbol design.

The script I'll be using, if anyone wants a peek, lives here.

palob commented 6 years ago

We should probably skip the steam ones and do them later. Most of them got renamed.

palob commented 6 years ago

Turns out almost none of the icons made for #3481 is ticked off here.

palob commented 6 years ago

I'm currently not proceeding alphabetically but rather fixing the most obviously broken ones first.

palob commented 6 years ago

Another way of seeing whether or not a Square icon has been updated yet is comparing file sizes. If on par (and carrying the same symbol design ofc) the Square icon should be a smaller file than the Circle icon.

Active clippings will become obvious when viewed in a Qt viewer (Gwenview, Nomacs).

bilelmoussaoui commented 6 years ago

Here's a list of icons that should be updated too https://pastebin.com/raw/fGJF1Eh8 The list contains the icons that still has a one-line SVG (old optimization options)

bilelmoussaoui commented 6 years ago

I'm going to write a test that verifies every icon if it does follow the optimization options :) which will gives the real list :p

palob commented 6 years ago

I hope it will. Since it does not verify visual insufficiencies there might be outdated designs with correct optimisation.

palob commented 4 years ago

With my latest PRs merged I think this can be safely closed. If there are any issues left those will only be about lacking optimisation/bigger than neccessary filesize. Whenever I stumble upon something I'm going to fix it.

What's left is the redesign of the jetbrains icons (which depends on the outcome of #3706), should be tracked individually.

Foggalong commented 4 years ago

Agree with that call :+1: