numixproject / numix-core

Builder for App Icon Themes
GNU General Public License v3.0
768 stars 146 forks source link

Runtime Steam Icons fix #5405

Closed BlueManCZ closed 4 years ago

BlueManCZ commented 4 years ago

I recently wrote this python script, to allow users to fix their runtime Steam icons. Some people may find it useful as I do.

Foggalong commented 4 years ago

This repository is for the themes' build environment rather than the theme packages themselves so it wouldn't be appropriate to list it here. This looks like a brilliant script though so I'd love it if you would submit a notice similar to the "Hardcoded Icons" section of the READMEs in our Circle and Square package repos so I can merge it there.

For context, the reason hardcode-fixer is listed in this repo is that in fixing launchers its uses its own list of icon names which are distinct from the names used by the original app. As an example, for DupeGuru it changes the icon line from Icon=/usr/share/dupeguru_se/dgse_logo_128.png to Icon=dupeguru. There isn't a standard icon called dupeguru so themes still have to create a new icon with that name. By having hardcode fixer listed here it just signifies that we also explicitly aim to cover the icon names which only come only from that script as well.

On the other hand, your fixer uses the standard icon names steam_icon_$appId which all icon themes aim to cover as part of their normal business since that's also the format Steam .desktop launchers use too. If a theme supports Steam apps it de-facto also supports your script. The same isn't true for Hardcode Fixer since extra icons are needed on the part of theme developers.