numixproject / numix-core

Builder for App Icon Themes
GNU General Public License v3.0
765 stars 146 forks source link

preferences-desktop-icons shouldn't be a symlink to numix #5490

Open mueller-ma opened 5 years ago

mueller-ma commented 5 years ago

Screenshot from KeePassXC: keepassxc

The icon used for "Icon" shouldn't be the numix icon, but instead an "icon" icon. https://github.com/numixproject/numix-icon-theme-circle/blob/master/Numix-Circle/48/apps/preferences-desktop-icons.svg

Here's the request for a proper "preferences-desktop-icons" icon: https://github.com/numixproject/numix-core/issues/2908#issuecomment-484052740

palob commented 5 years ago

Hmm, I'm not sure they're using the correct icon name there.

mueller-ma commented 5 years ago

On my system (Debian 9 with Cinnamon) the settings GUI has an entry for "Themes" that has a different icon (https://github.com/numixproject/numix-icon-theme-circle/blob/master/Numix-Circle/48/apps/theme-config.svg).

Foggalong commented 4 years ago

@palob Didn't you recently make a new icon to do with icon themes? That might be a more suitable destination for that symlink

Foggalong commented 4 years ago

@mueller-ma For future reference, you submitted your request against the packaging repo (numix-icon-theme-circle) not against the development repo. Please consult the READMEs of repositories when submitting issues.

palob commented 4 years ago

Yeah, that was in #5119, the db icon name is icon-preview-app.

Foggalong commented 4 years ago

Aye I reckon that one works here too!