search

numixproject / numix-core

Builder for App Icon Themes
GNU General Public License v3.0
768 stars 146 forks source link

Wrong OpenERP symlink #5585

Closed palob closed 4 years ago

palob commented 4 years ago

We've got a symlink openerp-client to the root opera. Does this make a sense I fail to see?

Foggalong commented 4 years ago

This is definitely a bug, looking at the commit where it was added it will have been put there intending for it to be an app with a similar name, though not clear what :confused:

Foggalong commented 4 years ago

Actually perhaps it wasn't a bug - the OpenERP icon is almost identical to what Opera's icon used to be.

OpenERP Opera (pre-2015) Opera (post-2015) Numix Opera (2014)
ap_resize php external-content duckduckgo com external-content duckduckgo com Screenshot from 2020-09-11 12-17-43

When you compare it to what our Opera icon was in 2014 at the time OpenERP was introduced by yours truly in adc6a87dd152f02a931e80d39836a1f474aa9de1, it's not hard to imagine that I might have cut that corner and just made it a symlink instead. In the spirit of that laziness, I'm actually just gonna reintroduce the old opera icon with a colour switch be the new (old) OpenERP icon.

Foggalong commented 4 years ago

Fixed in #5587