numixproject / numix-core

Builder for App Icon Themes
GNU General Public License v3.0
768 stars 146 forks source link

Update Firefox icon #5597

Closed pieterdd closed 3 years ago

pieterdd commented 4 years ago

The last iteration of this Numix icon dates from 2016, so given the design changes to Firefox' branding over the last few years I thought I'd tweak this one a bit.

Original icon Circle icon Square icon
firefox firefox-new8 I will make this one when the circle version requires no further changes

Here's a first iteration. I'm not sure why I'm seeing some downsampling artifacts in my PNG render. GitHub's rich diff of the modified SVG looks normal to me.

pieterdd commented 4 years ago

Something among these lines?

test4-optimized

maxtron95 commented 4 years ago

Issue #4998

pieterdd commented 4 years ago

Okay. So should it be https://github.com/numixproject/numix-core/issues/4998#issuecomment-604796398 except with a shadow of the fox onto the marble?

palob commented 4 years ago

Yes, you can start from the latest state in that issue.

pieterdd commented 4 years ago

Alright, here we go:

firefox-ci-inkscaperender firefox-sq-inkscaperender

pieterdd commented 4 years ago

Just noticed that the export left some unnecessary metadata in the SVGs (like the original filename) for the circle file. I probably hit Save again after already having written the Optimized SVG version, nothing big.

pieterdd commented 4 years ago

Fixed.

pieterdd commented 4 years ago

Would you perhaps be willing to amend these changes to the commit yourself? I think you're the most qualified person to get it to look exactly the way you want, and it's probably faster than coaching me to execute your vision. I have enabled the 'Allow edits by maintainers' option.

Regardless, thanks for the insight into your creative process.

palob commented 4 years ago

Alright, I can take care of this, I'm a bit pressed for time at the moment though.

pieterdd commented 4 years ago

No worries, it's not urgent. When you do, feel free to add yourself as a co-author to the commit if you'd like to be credited.

palob commented 4 years ago

I'm working on this, might be ready this week.

palob commented 4 years ago

This is the current state. Inserted two extra path so the colour clashes aren't that hard without gradients. Colours and one or two curvatures might need tweaking, maybe the extra tail path isn't needed.

firefox-ci

palob commented 4 years ago

Here's what it looks like with a gradient on the globe. firefox-gradient

maxtron95 commented 4 years ago

Wow, the new icon is way better than what I had proposed before.

palob commented 4 years ago

Pushed these (w/o globe gradient) firefox-ci firefox-sq

palob commented 4 years ago

If this is approved of I will redo the others (aurora, beta,...) as well.

pieterdd commented 4 years ago

Well, you certainly have my vote 😉 If you guys have a strong opinion about keeping the commit history clean, I suppose we could squash both commits into one now. Let me know if you'd like me to step in for that.

Either way, I'm happy to see that an updated Firefox icon is bound to arrive on my computer sometime soon!

pieterdd commented 4 years ago

What's the next step towards shipping a nice new Firefox icon? Are there still any changes needed?

palob commented 4 years ago

Waiting for a review from @Foggalong, merging a few more PRs and tagging new releases for Circle/Square.

Foggalong commented 3 years ago

Great work both! Updated the four non-branded accounts to use this style too, but if anyone wants to weak them further go for it; I just riffed on the colour scheme each was using before.

palob commented 3 years ago

Hats off for the recolours! I can look into this again, the upstream colour schemes might have changed.

dvorapa commented 3 years ago

Oh my god, this was merged one hour after the last release of numix-icon-theme-circle was published. What a miss!

Foggalong commented 3 years ago

@dvorapa If you means the PPA/AUR/other community repo then don't worry, the next release (shortly!) will contain this!

msevilla00 commented 3 years ago

@dvorapa I've just upgraded my system (Ubuntu 20.04) and I got the new icon. Cheers!

Foggalong commented 3 years ago

No problem at all!

dvorapa commented 3 years ago

I know, I just noticed how unlucky coincidence it was, as I'm waiting for a design update of this particular icon for a while now :D Anyway I really don't mind waiting for good stuff and have to say this icon pack is my all time favourite since I first installed Apricity Linux in 2015 I think!