search

numixproject / numix-core

Builder for App Icon Themes
GNU General Public License v3.0
765 stars 146 forks source link

add a few xfce entries #5684

Closed bgstack15 closed 3 years ago

bgstack15 commented 3 years ago

In tandem with #5624, here are a few extra xfce entries for xfce4-4.16.0 from Debian.

You will note that this patch does not include the "org.xfce.terminal" that 5624 does, but I don't know how to submit a patch onto that pull request.

palob commented 3 years ago

Hi, thank you for the PR. org.xfce.terminal-settings should be reordered, this is why the CI build fails.

This PR should not add any icon names which are already present in #5684, this way both PRs can be merged in sequence without further ado.

bgstack15 commented 3 years ago

I have fixed the order for org.xfce.terminal-settings as indicated.

And I assume you meant that I should make sure I do not duplicate any new entries from #5624. I had already reviewed it before submitting this initially, and these contents do not overlap but some of the additions are adjacent so unfortunately some manual fixing of the patches might be required.

bgstack15 commented 3 years ago

Does this need anything from my side to proceed?

palob commented 3 years ago

No, you've done your share.