search

numixproject / numix-core

Builder for App Icon Themes
GNU General Public License v3.0
768 stars 146 forks source link

Use Github Actions instead #5753

Closed barelyhuman closed 3 years ago

barelyhuman commented 3 years ago

For: https://github.com/orgs/numixproject/teams/team/discussions/2?from_comment=1#discussion-2-comment-1

Foggalong commented 3 years ago

@satya164 We have talked about using a Docker instance to handle that for Travis. We got as far as setting up a Numix account + instance before the contributor's (@bilelmoussaoui) time dried up

See #4048 for more details

barelyhuman commented 3 years ago

@satya164 can be cached if I move them to a requirements file and use pip cache instead, I’ll add that early tomorrow to the same

barelyhuman commented 3 years ago

@Foggalong done,

the time reduced from 1 min 5 seconds to 35-45 seconds that is considering there's no updates needed and only installing the needed packages from the pip cache and checking if they need an upgrade, we can further reduce this by freezing the versions of each package

Foggalong commented 3 years ago

Will merge this tonight and clean up any Travis cruft left on our account :+1:

Foggalong commented 3 years ago

@barelyhuman Was there a particular reason for using --upgrade --upgrade-strategy eager? I was tinkering with the actions today because I'm adding a new step to fix #4786 and noticed use of those flags constitutes half of the builds runtime. I've removed them in python-clean where I'm working but if there was a reason let me know and I'll add it back :slightly_smiling_face:

barelyhuman commented 3 years ago

Thats in case we froze the versions, since we didn’t it’s fine

Foggalong commented 3 years ago

Aces, cheers @barelyhuman!