search

numixproject / numix-core

Builder for App Icon Themes
GNU General Public License v3.0
765 stars 146 forks source link

Added winbox icon #5777

Open ingria opened 2 years ago

ingria commented 2 years ago

Fixed crescent shapes and fitted them into 30px circle.

Original icon Circle icon Square icon

See also #5742, fixes #5740.

source svg ![winbox](https://user-images.githubusercontent.com/2178368/154873640-4918fc18-1aea-46dc-9350-325a3d526aaa.svg)
ingria commented 2 years ago

Just found this unofficial snap: https://snapcraft.io/winbox

Is it possible to support it too? Its .desktop file is here.

palob commented 2 years ago

No, as soon as there is a / in the Icon= line this means the icon path is hardcoded and you need to edit the .desktop file.

I know it's from the original PR but I don't think the .exe symlinks in data.json will work. They should be removed.

palob commented 2 years ago

Thank you for the PRs. There symbol should be smaller still (and moved up/to the right maybe) so that it fits into a centered 30x30 circle.

circcle

mrmeszaros commented 1 year ago

The drop shadow seems off to me. For the circle it is usually offset to the bottom right (1, 1). For the square it is offset to the bottom (0, 1).

Also, just a heads up, You don't have to amend the commit and force-push - all commits on the branch are rebased and squashed into one when merging.

palob commented 1 year ago

Additional icon name com.mikrotik.Winbox required.