search

numixproject / numix-folders

Alternate folders for use with our base icon theme.
GNU General Public License v3.0
152 stars 26 forks source link

add gtk & notify version check #124

Closed bilelmoussaoui closed 8 years ago

dirtydancing commented 8 years ago

Confirmed that there are no warnings with this version anymore :+1:

@bil-elmoussaoui Is there a reason why your fork is from @wa4557 and not from numixproject?

bilelmoussaoui commented 8 years ago

@dirtydancing i forked @wa4557 to fix an issue with gui and i forgot to delete and refork numixproject again :P

dirtydancing commented 8 years ago

Ah ok, was just wondering. I guess that this should not cause any merging problems.

Foggalong commented 8 years ago

It took me way too long to work out that this was a different file :P

Foggalong commented 8 years ago

@dirtydancing will the error file require this check also?

bilelmoussaoui commented 8 years ago

@Foggalong yes but only the gtk version check

Foggalong commented 8 years ago

:+1:

dirtydancing commented 8 years ago

Argh, now the warning when opening is back, but the two warnings when running are gone:

sys:1: PyGIWarning: Gtk was imported without specifying a version first. Use gi.require_version('Gtk', '3.0') before import to ensure that the right version gets loaded.
dirtydancing commented 8 years ago

Just putting in a link to the issue to keep track https://github.com/numixproject/numix-folders/issues/121

dirtydancing commented 8 years ago

I just checked again, and apparently, I made a mistake at my end: all is running without any warnings. Sorry for causing potential confusion.

dirtydancing commented 8 years ago

Ah, I guess there were now no warnings anymore because of the latest https://github.com/numixproject/numix-folders/commit/10dcafde7c92705893e0de1dff22f16cbd8d664b