search

numixproject / numix-folders

Alternate folders for use with our base icon theme.
GNU General Public License v3.0
152 stars 26 forks source link

Gui not working on Linux Mint 17.3 #143

Closed f380cedric closed 8 years ago

f380cedric commented 8 years ago

I tried with sudo. Here the output 

Traceback (most recent call last):
  File "/opt/numix-folders/gui/gui", line 220, in on_activate
    self.colourentries[i].set_max_width_chars(7)
AttributeError: 'Entry' object has no attribute 'set_max_width_chars'
bilelmoussaoui commented 8 years ago

@f380cedric really weird :o maybe something with the Gtk version, can you paste the output of dpkg --get-selections | grep gtk?

f380cedric commented 8 years ago 
gir1.2-gtk-3.0                  install
gir1.2-gtkclutter-1.0               install
gir1.2-gtksource-3.0                install
gir1.2-javascriptcoregtk-3.0            install
gir1.2-nmgtk-1.0                install
gtk2-engines:amd64              install
gtk2-engines:i386               install
gtk2-engines-murrine:amd64          install
gtk2-engines-murrine:i386           install
gtk2-engines-oxygen:i386            install
gtk2-engines-pixbuf:amd64           install
gtk2-engines-pixbuf:i386            install
gtk3-engines-unico:amd64            install
ibus-gtk:i386                   install
libcanberra-gtk-module:amd64            install
libcanberra-gtk-module:i386         install
libcanberra-gtk0:amd64              install
libcanberra-gtk0:i386               install
libcanberra-gtk3-0:amd64            install
libcanberra-gtk3-module:amd64           install
libclutter-gtk-1.0-0:amd64          install
libclutter-gtk-1.0-dbg:amd64            install
libdbusmenu-gtk3-4:amd64            install
libdbusmenu-gtk4:amd64              install
libgtk-3-0:amd64                install
libgtk-3-0-dbg:amd64                install
libgtk-3-bin                    install
libgtk-3-common                 install
libgtk-3-dev                    install
libgtk-sharp-beans-cil              install
libgtk2-perl                    install
libgtk2.0-0:amd64               install
libgtk2.0-0:i386                install
libgtk2.0-0-dbg                 install
libgtk2.0-bin                   install
libgtk2.0-cil                   install
libgtk2.0-common                install
libgtkglext1                    install
libgtkhtml-4.0-0                deinstall
libgtkhtml-editor-4.0-0             deinstall
libgtkmm-2.4-1c2a:amd64             install
libgtkmm-3.0-1:amd64                install
libgtksourceview-3.0-1:amd64            install
libgtksourceview-3.0-common         install
libgtksourceview2.0-0               install
libgtksourceview2.0-common          install
libgtkspell0                    install
libjavascriptcoregtk-1.0-0:amd64        install
libjavascriptcoregtk-3.0-0:amd64        install
libnm-gtk-common                install
libnm-gtk0                  install
libreoffice-gtk                 install
libswt-cairo-gtk-3-jni              install
libswt-gtk-3-java               install
libswt-gtk-3-jni                install
libswt-webkit-gtk-3-jni             install
libwebkit2gtk-3.0-25:amd64          install
libwebkitgtk-1.0-0:amd64            install
libwebkitgtk-1.0-common             install
libwebkitgtk-3.0-0:amd64            install
libwebkitgtk-3.0-common             install
libwmf0.2-7-gtk                 install
libwxgtk2.8-0:amd64             install
lightdm-gtk-greeter             install
mint-themes-gtk3                install
numix-gtk-theme                 install
python-aptdaemon.gtk3widgets            install
python-gtk2                 install
python-gtksourceview2               install
python3-aptdaemon.gtk3widgets           install
transmission-gtk                install
xdg-user-dirs-gtk               install
bilelmoussaoui commented 8 years ago

Can you create an empty python file and put this code on it, execute the script using terminal (python3) and paste the output

from gi.repository import Gtk
print(Gtk.get_major_version())
print(Gtk.get_minor_version())
f380cedric commented 8 years ago 
3
10
bilelmoussaoui commented 8 years ago

I don't know why this is happening.. and i can't test it right now. You can modify the file in /opt/numix-folders/gui/gui manually and remove this line self.colourentries[i].set_max_width_chars(7) everything should work fine but the gui will look a little bit out of place

f380cedric commented 8 years ago

It seems that set_max_width_chars was introduced with the 3.12 version of Gtk, I am on 3.10 (there)

bilelmoussaoui commented 8 years ago

@wa4557 @dirtydancing What do you guys think about this? if we remove the set_max_width_chars the gui will look really ugly... screenshot from 2016-01-06 11-23-47 I still don't understand why some distros are still using a very old version of GTK... :(

andia89 commented 8 years ago

An if condition and if Gtk>=3.12 is used set the property?

bilelmoussaoui commented 8 years ago

But still the gui will look ugly for old versions :P

dirtydancing commented 8 years ago

I can get back to this later. First thought: yeah, the GUI would look really ugly like that, after all the refining it has undergone. Second thought: Is this based on Ubuntu 14.04 LTS? Ubuntu 14.04 LTS should be supported if possible. Third thought: Maybe have two different GUI versions depending on the Gtk version? That way, all "modern" distros would profit, while the "old" ones would still be served.

bilelmoussaoui commented 8 years ago

@dirtydancing i have no idea, but i think that ubuntu 14.04 uses gtk 3.12. I prefer creating two GUI versions, we use the old design for older version < 3.12 and we keep this new version for gtk >= 3.14. Let's see what @Foggalong think about this

Foggalong commented 8 years ago

I'd much sooner have an if condition than maintain multiple versions.

f380cedric commented 8 years ago

@bil-elmoussaoui I think that Ubuntu 14.04 still use gtk 3.10 (source)

dirtydancing commented 8 years ago

@f380cedric Could you check if the pull request over at https://github.com/numixproject/numix-folders/pull/144 works for you, i.e. does your GUI look like the first one displayed over there? This is the relevant branch to test: https://github.com/bil-elmoussaoui/numix-folders/tree/patch-2

The GUI is working fine just as before with Arch/GNOME. This is Gtk 3.18, so it looks like the second screenshot over at https://github.com/numixproject/numix-folders/pull/144#issue-125162480.

f380cedric commented 8 years ago

@dirtydancing from there, I have this Numix-Folders-Path-2

dirtydancing commented 8 years ago

Well, this looks OK imo, although a little different than in the other screenshot.

@bil-elmoussaoui Any idea why the title is Numix Folders GUI and not Numix Folders like in your screenshot for older Gtk versions?

bilelmoussaoui commented 8 years ago

@dirtydancing i have no idea :p i didn't change the title, as you can see in the source code in my commit! @f380cedric Can you copy/paste the source of gui file in pastebin and paste the link here?

f380cedric commented 8 years ago

@bil-elmoussaoui http://pastebin.com/pSVbPiM7 For info, I do not know if I do it well (I use the numix ppa, not git). So I removed the numix-folder package via apt, then git clone https://github.com/bil-elmoussaoui/numix-folders/tree/patch-2 and run "numix-folders" file via sudo

bilelmoussaoui commented 8 years ago

I see, you've cloned the main repo that's why.. once you've cloned the repo you need to run git pull origin patch-2

f380cedric commented 8 years ago

Ha, I thought that copy url from path-2 was sufficient to clone this part of the repo -_- sorry :/ So, with the good branch (you have conflit between your master and patch 2) I have this Numix Folders

bilelmoussaoui commented 8 years ago

@f380cedric not a problem :) i fixed a small issue, it should work fine now. Can you try again?

f380cedric commented 8 years ago

@bil-elmoussaoui If I try to merge origin master (origin is your repo) with origin patch-2, I have conflit. After solving it, I have capture du 2016-01-06 20 50 48

bilelmoussaoui commented 8 years ago

Looks fine for me :+1:

dirtydancing commented 8 years ago

Agreed :+1:

And here is a screenshot with Arch/GNOME (Gtk 3.18), all fine here as well:

numix-folders