numixproject / numix-folders

Alternate folders for use with our base icon theme.
GNU General Public License v3.0
151 stars 26 forks source link

Add wine-winefile icons #176

Closed mymindstorm closed 7 years ago

mymindstorm commented 7 years ago

The icons should be fine except for perfect grid alignment on the X axis because I kept the symbol proportional.

Is there something like data.json that I need to edit here to get them to work correctly?

mymindstorm commented 7 years ago

Sorry for the blurriness, Nautilus doesn't like to scale things properly. image

mymindstorm commented 7 years ago

@palob @Foggalong since there hasn't been an update in a week on this I was wondering if I need to do anything, if nobody had the time for this yet, or if this just got forgotten

Foggalong commented 7 years ago

@mymindstorm I'll be honest, I just never saw the notification! Pinned this so it'll be the next review I do :)

mymindstorm commented 7 years ago

Thanks!

On Aug 1, 2017 3:48 PM, "Joshua H. Fogg" notifications@github.com wrote:

@mymindstorm https://github.com/mymindstorm I'll be honest, I just never saw the notification! Pinned this so it'll be the next review I do :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/numixproject/numix-folders/pull/176#issuecomment-319492180, or mute the thread https://github.com/notifications/unsubscribe-auth/AagJ7pXpfdeJPGslY1b6ilMP_TCoqWeHks5sT479gaJpZM4OjBUr .

mymindstorm commented 7 years ago

I don't see what's wrong with it, the shadow on the folder is already 1px down and to the right? image

Also, when I was double checking the other style 5 icons I noticed that some of them used 2px between the symbol and left side of the folder while other icons used 3px

image image

Is there a size I should be using here?

palob commented 7 years ago

@Foggalong was referring to the symbols on top of the folders. As a matter of fact however it's that way (just 1px down) on all the other icons, be it on purpose or by mistake.

Foggalong commented 7 years ago

@palob oh shit is it really? I have no idea whether or not that is intentional and the answer is likely lost in the logs of the old Numix IRC channel where we used to do development. I'm gonna go with it being unintentional, but I'll merge this one now and then we can fix the rest at a later date