search

numixproject / numix-folders

Alternate folders for use with our base icon theme.
GNU General Public License v3.0
151 stars 26 forks source link

Question on v2 branch #186

Closed Tank-Missile closed 4 years ago

Tank-Missile commented 5 years ago

I noticed there was a v2 branch. Is that branch abandoned, or should I focus on it for adding features, etc?

palob commented 5 years ago

v2 is the way to go. @bilelmoussaoui Did you work on it since your last commit?

bilelmoussaoui commented 5 years ago

Oh, I completely forgot that I started a rewrite a long time ago. Feel free to you use that, but it's not working at all. If you need any guidance or help getting something working, please ping me.

Tank-Missile commented 5 years ago

If that's the case, perhaps I should just start from scratch? I was hoping to make a better UI in Qt. Obviously, it would be a frontend to the existing cli. I may even rewrite that since I've found issues with it, such as it not accepting color input, etc.

bilelmoussaoui commented 5 years ago

I haven't done any Qt in a while, not sure I would be able to review your work later. Let's see what @palob & @Foggalong think about this

palob commented 5 years ago

The current implementation uses PyGObject. @Tank-Missile But if you want to contribute and fix the issues you are free to do whatever floats your boat.

Foggalong commented 5 years ago

I'd sooner not have it in Qt for the plain and simple reason that the vast majority of Numix users are using a GTK based distribution. Having this app be Qt would mean that a load of additional dependencies the user likely doesn't have would need bringing in.

I don't actually use the GUI version of this at all but I'm not opposed to someone else coming in and rewriting the UI from scratch if it's going to be an improvement / fix to what we currently have. I'm aware it's probably some time since it had some love.