search

numixproject / numix-folders

Alternate folders for use with our base icon theme.
GNU General Public License v3.0
151 stars 26 forks source link

Remove the default colour images. #187

Closed Hebgbs closed 4 years ago

Hebgbs commented 4 years ago

There isn't a reason to bloat the application with images for default colour selections. In my testing, at least on Ubuntu 19.04 (after transplanting obsoleted deps from three years ago) the app's custom routine works just fine, and the application would be way simplified if it did only the custom routine with the other colour options just being custom presets instead.

Foggalong commented 4 years ago

I'm not going to lie I don't understand what you're trying to say. Would you be able to rephrase it more clearly, perhaps with a screenshot illustrating what you mean?

Hebgbs commented 4 years ago

I mean, exactly what I said. The pre-rendered default colour option images for all things which aren't Custom don't need to be there. At least, in my iteration of numix-colors there appear to be images for the default selection of available colours which aren't custom, and I believe them to be a waste of space when the custom routine works just fine, and you can pare down the application, as well its overall package size by omitting this and keeping only the options fr custom colour, making the default selection only presets for the custom routine.

Unless I am delusional. I will have to look again but I swear I've seen duplicate files with slightly different names because they're different colours.

Hebgbs commented 4 years ago

Yeah, here's what mean: Refactor the application so it doesn't rely on pre-fabricated images for default colours. So this would mean, based off of the PPA remove the following:

/opt/numix-folders/styles/0
/opt/numix-folders/styles/*/*/*/*/blue-*
/opt/numix-folders/styles/*/*/*/*/brown-*
/opt/numix-folders/styles/*/*/*/*/default-*
/opt/numix-folders/styles/*/*/*/*/green-*
/opt/numix-folders/styles/*/*/*/*/grey-*
/opt/numix-folders/styles/*/*/*/*/orange-*
/opt/numix-folders/styles/*/*/*/*/pink-*
/opt/numix-folders/styles/*/*/*/*/purple-*
/opt/numix-folders/styles/*/*/*/*/red-*
/opt/numix-folders/styles/*/*/*/*/yellow-*

This would leave only the custom files, which the custom routine already colourizes as defined by the user which would shed a fair bit of fat from the overall package. One could also get rid of /opt/numix-folders/colours since that isn't really necessary to call upon when everything should be handled in the program anyway, unless that's there for a colourize function via imagemagick but honestly they don't need to be there if the custom option routine was the only thing the program did.

And also, make it use pkexec instead of gksu. And fix colour picker so it changes the hex value shown, and update the preview. And add a fallback for when a user doesn't have elevated privilege by telling them it will only work on local copy, and to have the icons in /home/$cuser/.icons before using this application.

Foggalong commented 4 years ago

We're aware of the pkexec vs gksu issue and it's something that'll be addressed if the GUI version is ever returned to (at the moment it is defacto unmaintained).

I'm still not really clear what your main point is though: are you saying to remove all icons except those of the format */custom-*.svg and then just have, for example, the blue folders be a recolouring of those at runtime?

Foggalong commented 4 years ago

Closed due to lack of response from original reporter.

If what I said above was your question, then the reason we don't do that because they're there as part of the Folder Colors application; they're not here just for use with this app.