numixproject / numix-gtk-theme

A modern flat theme with a combination of light and dark elements.
GNU General Public License v3.0
1.19k stars 228 forks source link

Some parts of the UI are black and probably shouldn't be (gedit & backup) #121

Closed vitalykorolev closed 10 years ago

vitalykorolev commented 10 years ago

(In Ubuntu 14.04 LTS) 1: Backup app (System Settings > Backups > Back Up Now...) shows some backgrounds in black which looks bad. screenshot from 2014-04-23 08 41 40

2: Gedit has a black background behind tabbar and when all tabs are closed. screenshot from 2014-04-23 08 42 15 screenshot from 2014-04-23 08 42 24

sergeyhoh commented 10 years ago

For Ubuntu 14.04, I added the following in /usr/share/themes/Numix/gtk-3.0/gtk-widgets.css,

GtkWindow {
    color: @fg_color;
    background-color: @bg_color;
}
GtkPaned {
    background-color: @bg_color;
}
GtkEventBox {
    background-color: @bg_color;
}

and, it fixed a black background.

satya164 commented 10 years ago

@PaoloRotolo isn't the overlay-scrollbar patch included yet?

satya164 commented 10 years ago

BTW disable overlay scrollbars and the bug should be gone.

harsesus commented 10 years ago

I am in version:

2.2+294~201404231512~ubuntu14.04.1

Not sure if the fix just hasn't gotten down to me yet. I have the issue, and it also causes nemo to go all black. Not sure if nautilus does it as well. It seems to be tied to certain events, one of which I think is 'apt-get update'.

Here is a screenshot: https://i.imgur.com/DsyYfrd.png

satya164 commented 10 years ago

@harsesus As said above, the bug is caused due to overlay-scrollbars. Please disable overlay scrollbars to fix it.

vitalykorolev commented 10 years ago

@satya164 what you're suggesting is a workaround and not a fix. Problem with gedit is gone with the latest update from PPA. However backup app is still showing blacks in weird places like shown in the screenshot.

satya164 commented 10 years ago

@vitalykorolev Yes. But the bug is in overlay scrollbars. I'm doing whatever I can to fix this at theme level by using hacky ways. This bug should be really fixed in overlay scrollbar level, and not in themes.

https://bugs.launchpad.net/ubuntu/+source/gtk+3.0/+bug/1059374

vitalykorolev commented 10 years ago

@satya164 I see your point. How does default Ambiance theme avoids this issue? By the way, today's PPA update brought back the black in gedit. :(

satya164 commented 10 years ago

@vitalykorolev Ambiance uses a hacky way by setting bg color for universal selector. We use patches to do that for Ubuntu. Prolly patches failed today. Will check.

Tammuz commented 10 years ago

I can confirm this issue, using comment 2 solution fixes the problem.

pinumbernumber commented 10 years ago

This is still present, comment 2 still fixes it.

(Disabling overlay scrollbar also fixes it, but I'd prefer to keep them)

satya164 commented 10 years ago

Well, it's a bug with overlay scrollbars, and it's canonical's responsibility to fix. The bug was reported long back and still hasn't been fixed. On Sep 30, 2014 10:15 PM, "pinumbernumber" notifications@github.com wrote:

This is still present, comment 2 still fixes it.

(Disabling overlay scrollbar also fixes it, but I'd prefer to keep them)

— Reply to this email directly or view it on GitHub https://github.com/shimmerproject/Numix/issues/121#issuecomment-57344011 .

pinumbernumber commented 10 years ago

Fair enough, I can understand not wanting to add hacks for one particular distro.

(They probably won't fix it, though, and Unity is popular, so it might be pragmatic to add it if it doesn't negatively affect anything else.

Alternatively, what about having the installation script in the Ubuntu PPA packages adding the hacky fix to the file after the fact? That way it doesn't need to be upstream.)

satya164 commented 10 years ago

We had a patch for Ubuntu in the PPA. It's failing for some reason. We'll check why.

On 1 October 2014 01:10, pinumbernumber notifications@github.com wrote:

Fair enough, I can understand not wanting to add hacks for one particular distro.

(They probably won't fix it, though, and Unity is popular, so it might be pragmatic to add it if it doesn't negatively affect anything else.

Alternatively, what about having the installation script in the Ubuntu PPA packages adding the hacky fix to the file after the fact? That way it doesn't need to be upstream.)

— Reply to this email directly or view it on GitHub https://github.com/shimmerproject/Numix/issues/121#issuecomment-57370475 .

Satyajit Sahoo Digital artist DeviantArt Profile http://satya164.deviantart.com

We're all stories, in the end. Just make it a good one, eh? — The Doctor, Season 5, Episode 13.

khurshid-alam commented 10 years ago

@satya164

We had a patch for Ubuntu in the PPA. It's failing for some reason.

What do you mean by that? Is it included or is it not? Can you tell me what exactly the patch is (or provide me a link to patch)? AFAIK it is to add a global inherit color to base states of gtk-widgets.css. * { /* inherit colors from parent */ color: inherit; background-color: inherit; } Right? Or is it something else?

I have reported again again that even though it seems that the issue is with overlay scrollbar, it may not have to be the only issue. Gtk+ breaks themes so often that it is hard to figure out what it was exactly. As far I remember all these started with introduction with gtk-headerbar & compiz (& unity window decorator) in Ubuntu still does not have support for headerbar.

I have tested with two separate version of Numix (on Ubuntu 14.10), Numix 1.8 from repo & the ppa version. I can confirm that even with the hack (if it is applied on repo & ppa), it still shows black bar in some areas (for both versions).

Screenshot:

image-1

However, I have old numix theme (probably before this commit: https://github.com/shimmerproject/Numix/commit/c3a8c0a39863f4520807944eaf88ac1b688fac7a) which was still using old tab design & light gtk-headerbar & titlebar. With that theme, there is no black area or no black bar at all even with overlay-scrollbar.

Screenshots:

image-2 image-3

So, how exactly was is working with overlay-scrollbar? Everything seems so perfect with the theme except toolbar-menu button which is normal because at the point it was still shaping up for 3.12.

If you want I can give you the diff between gtk-widget.css (old & new). I really want to get this bug fixed permanently.

vitalykorolev commented 10 years ago

+1 for @khurshid-alam

jxu commented 8 years ago

I still have the black bar issue with gedit with Ubuntu 14.04. https://github.com/numixproject/numix-gtk-theme/issues/121#issuecomment-41266145 fixed it.