search

numixproject / numix-gtk-theme

A modern flat theme with a combination of light and dark elements.
GNU General Public License v3.0
1.19k stars 228 forks source link

GTK 3.20 :: Toolbar/inlinetoolbar :: Button separator bug #557

Open megax opened 8 years ago

megax commented 8 years ago

image image image

megax commented 8 years ago

@lots0logs Idea?

lots0logs commented 8 years ago

Which application is that?

megax commented 8 years ago

gedit -> print sample nautilus -> settings

old mistakes, i forgot to send in =/ (https://github.com/numixproject/numix-gtk-theme/commit/4fb890854cb8bbeb7153e21daff5b7cd41598490 I've seen here) Base inline-toolbar code ok. A special code will be here... =/

khurshid-alam commented 8 years ago

@megax Did you try using separator code inside inline-toolbar? Although it should get inherited from primary-toolbar.

megax commented 8 years ago

@khurshid-alam I tried but ran out of idea. =/

lots0logs commented 8 years ago

I will try and take a closer look at this today...

megax commented 8 years ago

Related bug: Adwaita: image

Numix: image

megax commented 8 years ago

Maybe the problem here: https://github.com/numixproject/numix-gtk-theme/blob/2.6.5/src/gtk-3.20/scss/widgets/_button.scss#L87

khurshid-alam commented 7 years ago

@megax Still reproducible in 3.22?

megax commented 7 years ago

@khurshid-alam Yes, reproducible =/

khurshid-alam commented 7 years ago

I don't think we can do much here other than separating toolbar link-button code from inline-toolbar link-button. May be we should target Gtk-4 for this.