search

numixproject / numix-gtk-theme

A modern flat theme with a combination of light and dark elements.
GNU General Public License v3.0
1.19k stars 227 forks source link

GTK 3.20 :: Optimized notebook padding 2 #613

Closed megax closed 8 years ago

megax commented 8 years ago

Before: image

After: image

megax commented 8 years ago

@khurshid-alam Optimized padding. Again... :) (@lots0logs somehow removed git :D)

megax commented 8 years ago

@khurshid-alam Corrected and tested.

lots0logs commented 8 years ago

@khurshid-alam @megax I really wish this wouldnt have been merged so quickly. I want to discuss why you guys keep making everything smaller and smaller with less and less padding. Tabs should be larger than the text that is inside of them. This does not look good at all :unamused:

lots0logs commented 8 years ago

@khurshid-alam Optimized padding. Again... :) (@lots0logs somehow removed git :D)

btw, I did it on purpose.

khurshid-alam commented 8 years ago

Top/bottom padding is bit too large in my view as it's >toolbar height and == headerbar height (toolbar & headerbar were reduced recently). So it suffers on anything less than 1920x1080. It's hard to find a middle ground but 5/10 or 6/12 should be good for both.

lots0logs commented 8 years ago

(toolbar & headerbar were reduced recently).

A change that I was also against but I digress....

The tabs in the "After" screenshot don't have enough padding in this case. It might as well just be the text without any container at all (IJS).

khurshid-alam commented 8 years ago

Yes. That screenshot is using 4/8 which is bit too low. 5/10 is what we are using in 3.18.

And I didn't realize that megax changed and added back removed code.

khurshid-alam commented 8 years ago

Adwaita Compact one of the prime example of symmetric padding (https://github.com/abihf/adwaita-compact). It can grow from very minimal to very large.

And now that Gsk is merged with Gtk-3.24/4.0 something like this will also be possible in near future: Scalable-Adwaita https://github.com/GNOME/gtk/tree/wip/lapo/scalable-adwaita