numixproject / numix-gtk-theme

A modern flat theme with a combination of light and dark elements.
GNU General Public License v3.0
1.19k stars 228 forks source link

GTK 3.20 :: Optimised headerbar and titlebar size #614

Open megax opened 7 years ago

megax commented 7 years ago

Gnome-shell: image

Cinnamon: image

Ubuntu: image

megax commented 7 years ago

@khurshid-alam Minimal optimization. So look better. Right at lower resolutions. :)

khurshid-alam commented 7 years ago

Is it?

megax commented 7 years ago

@khurshid-alam This? :) Maybe it is strange for the first time. I think we should have take a picture of the current state as well. If you compare, you can see that between the button's and headerbar;titlebar's edges is a large amount of space, which is strange. I didn't repair long time ago, because the code wasn't assemled and tested. Now we could do it, I tested and have time to refine it. It is just an optical tuning and looks better on smaller screen by the way. It gives it a kind of old numix style when it was such thin. I didn't want to open a new Issue for it. Retrospectively I am sorry for that! Please test it, I've already done it and I couldn't find any regressions. (Only the character size, but it is depend on the settings as before. The theme can't help on it.. It is depend on the user too.)

khurshid-alam commented 7 years ago

Padding is too less here. Only thing it does that it puts switches and buttons inline.

....you compare, you can see that between the button's and headerbar;titlebar's edges is a large amount of space, which is strange.

There are other areas which are proportionally large (nautilus sidebar selection etc) which needs to be fixed first.

I put this on hold.

megax commented 7 years ago

Okay :)