search

numixproject / numix-gtk-theme

A modern flat theme with a combination of light and dark elements.
GNU General Public License v3.0
1.19k stars 228 forks source link

Fix for volume OSD progress bar #627

Closed nazar-pc closed 7 years ago

nazar-pc commented 7 years ago
Before After
2016-10-31 14-13-57 2016-11-01 02-12-13
2016-10-31 14-14-11 2016-11-01 02-12-38

Looking more into differences between 3.0 and 3.20 versions I believe some other things might be added as well, here is a diff of the part of _osd from 3.0 and 3.20: 2016-11-01 02-19-28 &.slider makes sense, but plain slider doesn't seem to be correct.

Fixes #623

khurshid-alam commented 7 years ago

Please rebase.

megax commented 7 years ago

@nazar-pc

&.slider makes sense, but plain slider doesn't seem to be correct.

New GTK 3.20 format (Reference code): https://github.com/GNOME/gtk/blob/gtk-3-22/gtk/theme/Adwaita/_common.scss#L2900 .osd slider

nazar-pc commented 7 years ago

Then I'll also add selector instead of replacing, it might be different in 3.20+ (source code that renders this OSD in my environment comes from 3.8 times). Will rebase in few hours, not at home right now.

nazar-pc commented 7 years ago

Rebased and changed as suggested