numixproject / numix-gtk-theme

A modern flat theme with a combination of light and dark elements.
GNU General Public License v3.0
1.19k stars 228 forks source link

GTK 3.20 :: Support for new Unity appearance option "Show the menus for a window: In the window's title bar" #632

Closed Sadi58 closed 7 years ago

Sadi58 commented 7 years ago

Behavior for hover/selection on Ubuntu's Unity top panel, which also serves as title/menu bar for maximized windows (as well as global menu bar, which now is optional) is a lighter grey bgcolor, but if the new option "Show the menus for a window: In the window's title bar" is selected, there's no difference at all for hover/selection on the title/menu bar of unmaximized app windows (GTK 2/3) .

On the other hand, when you open Synaptic Package Manager as root, the menu bar hover/selection behavior is the same as Unity top panel, i.e. lighter grey bgcolor.

Unity top panel: unity Nautilus window: nautilus Nautilus maximized window - using top panel as menu bar: nautilusmax Synaptic window: synaptic

khurshid-alam commented 7 years ago

@Sadi58 Screenshot?

Sadi58 commented 7 years ago

@khurshid-alam Edited above now with screenshots.

khurshid-alam commented 7 years ago

If I am not wrong...the second screenshot of nautilus is without root and 3rd is with root? Do you have numix related themes under ~/.themes? If you do, try removing those.

And why nautilus is not showing horizontal global menu for non root window?

Sadi58 commented 7 years ago

Only Synaptic Package Manager is with root in the screenshots above. I'm using a tweaked version of Numix (changing only selection bgcolor and the like to blue) named Numix-Blue, but I switched to default Numix, removed my Numix-Blue, and saw no difference (naturally). I use Unity with menus displayed in app window title bar (new option) instead of global menu bar (Unity top panel) unless they're maximized. So I think this must be the cause of this - probably Numix GTK theme assumes the users have only a global menu. When I change my settings to use global menu bar, naturally this inconsistency disappears.

khurshid-alam commented 7 years ago

For me it's ok....

screenshot

About nautilus, Unity's global menu patch is broken for nautilus on 16.10 I guess.

Sadi58 commented 7 years ago

It seems I couldn't make myself clear enough, sorry. This is also what I see (1) when I have a maximised app window, and also (2) when I choose System Settings... > Personal: Appearance > Behaviour: Show the menus for a window: In the menu bar.

The problem appears only when you choose to see the menus In the window's title bar instead of the global menu bar (i.e. Unity top panel)

I'm ignorant about theming, but it seems to me like menu bar behaviour is defined for global menu bar only, although in the past I used to see sort of Unity.Window.Decoration section, I don't know...

Or maybe this is due to a Unity bug that causes app windows (title bar) to fail in taking over the function of the global menu bar.

As a result I should better go back to the use of global menu bar again for the sake of consistency (although it's somettimes inconvenient when a large external monitor is connected) at least until this problem is resolved.

khurshid-alam commented 7 years ago

It seems .menu style is overwriting titlebar menu style (bg color) when using local menu-bar. Could be a unity bug. I will try and reproduce in zesty.

Sadi58 commented 7 years ago

FYI: Some other GTK themes like Greybird don't have this problem. So maybe the their CSS coding for menubar covers this new Unity feature as well.

megax commented 7 years ago

@Sadi58, @khurshid-alam Fixed code: https://github.com/numixproject/numix-gtk-theme/pull/647 Please test.

Sadi58 commented 7 years ago

It seems this is for GTK 3.22 only. No change in GTK 3.20 (Ubuntu 16.10) even if I copy and paste that code to the relevant block in menubar section.

bilelmoussaoui commented 7 years ago

@Sadi58 you must build the theme. The code in the commit is a sass code;)

Sadi58 commented 7 years ago

@bil-elmoussaoui thanks, I know that... @khurshid-alam thanks, it's all OK now :-)