numixproject / numix-gtk-theme

A modern flat theme with a combination of light and dark elements.
GNU General Public License v3.0
1.2k stars 228 forks source link

XFCE Whisker Menu Support (Gtk 3?) #666

Closed flg closed 6 years ago

flg commented 7 years ago

Hello,

After upgrade to Xubuntu 17.04, it seems that the XFCE whisker menu (xfce-panel plugin) has lost support from Numix (I mean it appears pale grey whereas the theme is dark grey; and it used to be dark grey before upgrade). I suspect it could have something to do with port to Gtk 3.

If any information is needed, just ask. Thanks

mirkosrc commented 7 years ago

I have the same issue for the whisker menu. Also the background colour from the bars of xfce4-systemload-plugin is now white instead of black. Same for Okular pdf viewer background.

khurshid-alam commented 7 years ago

Screenshot ? Theme version? Is it using gtk-3 or gtk-2?

flg commented 7 years ago

This shows the problem on an up-to-date Xubuntu 17.04 with Numix daily (taken from ppa). problem

This shows how it is working properly on a CentOS 7 with Numix 2.6.0 (release 1.el7). ok

I don't how to tell if it is using Gtk 2 or 3. Any hint?

khurshid-alam commented 7 years ago

The upper one is gtk3. The lower one is gtk2. We need to change whiskermenu background color. I will create a fix.

c5e3 commented 7 years ago

i also noticed some change in 'gqrx', that uses gtk2 i guess before: before

after: after

MasterLink86 commented 7 years ago

c5e3, I wanted to let you know that is not a problem with Numix, 17.04 broke GTK themes from working in QT applications, like gqrx (which I use every day for emergency response).

I have a fix for it.

sudo add-apt-repository ppa:nilarimogard/webupd8 sudo apt-get update sudo apt-get install qt4-qtconfig qt5ct nano ~/.profile - Add this line: export QT_QPA_PLATFORMTHEME=qt5ct Log out, log in. Launch qtconfig-qt4 and qt5ct and set both to "gtk".

If you can't open qt5ct for whatever reason (it's a fickle beast), and it's complaining that the platformtheme variable isn't properly set, just type the line in terminal, then open qt5ct, then it'll open, so you can set the theme to gtk.. We just need to set it to gtk, as it's likely stuck on the default KDE theme (like your screenshot shows, and same as mine).

c5e3 commented 7 years ago

nice, big thx! :D turned out, only qt5 was configured wrong. i also had to change the fonts in qt5.

MasterLink86 commented 7 years ago

Ahh so it wasn't just me that had the fonts messed up too and looking overly large.

Glad it helped.

mirkosrc commented 7 years ago

@flg , did the fix, provided by @lnx64 , work for you ? The whisker menu and the background colour of the xfce4-systemload-plugin bar looking still white instead of numix dark for me.

flg commented 7 years ago

I think the solution provided by @lnx64 has nothing to do with the original problem but is related to fonts and integration of Gtk theming in QT applications. Meaning I did not try.

khurshid-alam commented 7 years ago

@Mirkosrc I haven't pushed the fix in master. It's in my local repo. Will do in next weekend.

mirkosrc commented 7 years ago

@khurshid-alam Great, thank you

Limator commented 7 years ago

@khurshid-alam This would be very nice! I like the dark whisker a lot more :D

MasterLink86 commented 7 years ago

@flg, correct, this fix I provided has nothing to do with the menu, it was simply for @c5e3 who thought the issue they had was related to this thread, but it was not.

Limator commented 7 years ago

Hi at all, could anyboy help to fix this color-issue? Thanks a lot!

ghost commented 7 years ago

I tried to fix the issue but couldn't find any way to change whiskermenu's coloring. Anyone got a hint where to look at?

ghost commented 7 years ago

Still no news on that issue?

Limator commented 7 years ago

HI @khurshid-alam , any new on your fix for the gtk3/gtk3.2 whisker menu-decoration?

khurshid-alam commented 7 years ago

It seems they have done something to checkbox between 2.1.1 & 2.1.2, also I could not override some styles from theme. It will be fixed after I fix panel-applets.

ghost commented 7 years ago

Any news on that issue? Do you need any help?

khurshid-alam commented 7 years ago

@tuxedovinz See https://bugzilla.xfce.org/show_bug.cgi?id=13646

Any help is always welcome. :)

Limator commented 7 years ago

Maybe this helps: If using gtk-dark.css as replacement for gtk.css (simple renaming it) the menu is dark ^^ Some other things are also dark, but I just want to say, that something inside the gtk-dark.css has also impact on the whiskermenu!

khurshid-alam commented 7 years ago

@hexum1 See https://bugzilla.xfce.org/show_bug.cgi?id=13646. It's broken on upstream. Without proper class it can not be themed.

However, You can use a custom gtk.css in ~/config/gtk-3.0.

mirkosrc commented 6 years ago

For me, the theme is black again, after adding gtk-application-prefer-dark-theme = true in ~/.config/gtk-3.0/settings.ini .

But the search bar background for Chrome is black too...

flg commented 6 years ago

Just wanted to comment that the (original) problem is still present: whisker menu has bright decoration when all the rest is dark.

gtk-application-prefer-dark-theme = true in ~/.config/gtk-3.0/settings.ini does not work for me.

Simon-the-Sorcerer commented 6 years ago

@flg Just create ~/.config/gtk-3.0/settings.ini and add

[Settings] gtk-application-prefer-dark-theme = true

to it. The whisker menu should be dark now.

flg commented 6 years ago

I was missing the header. That works thanks.

c0d3z3r0 commented 6 years ago

gtk-application-prefer-dark-theme breaks other applications like Chrome

c0d3z3r0 commented 6 years ago

Please test if that works for you, too. The default is to take xfce4-panel's css style but it can be overridden by ~/.config/gtk-3.0/gtk.css. https://github.com/gottcode/xfce4-whiskermenu-plugin/pull/113

c0d3z3r0 commented 6 years ago

As already mentioned in my xfce-whiskermenu issue my patch is not needed. This one works for me:

#whiskermenu-window {
  background-color: #000;
}

@khurshid-alam

khurshid-alam commented 6 years ago

@c0d3z3r0

Ah. I see. Can you open a pull? I think we also need a whiskermenu border ?

c0d3z3r0 commented 6 years ago

@khurshid-alam I am absolutely new to SCSS, so maybe you could convert this to SCSS? :-) This is what I am currently using:

#whiskermenu-window * {
  border: 0;
  outline: none;
}

#whiskermenu-window {
  background-color: #444;
  color: #ccc;
}

#whiskermenu-window entry {
  background-color: #555;
  color: #eee;
}

#whiskermenu-window button {
  background-color: #444;
  color: #ccc;
}

#whiskermenu-window treeview {
  background-color: #3e3e3e;
  color: #ccc;
}

#whiskermenu-window button:focus,
#whiskermenu-window button:hover,
#whiskermenu-window treeview:selected,
#whiskermenu-window treeview:hover
{
  background-color: #D64937;
  color: #fff;
}

image image