search

numixproject / numix-gtk-theme

A modern flat theme with a combination of light and dark elements.
GNU General Public License v3.0
1.2k stars 228 forks source link

xfce4-notifyd shows only themes that have css file #677

Closed sjb0x49 closed 6 years ago

sjb0x49 commented 7 years ago

Xfce4-notifyd no longer checks for gtkrc files for themes, it now accepts only gtk.css. The change was committed a while ago: https://git.xfce.org/apps/xfce4-notifyd/commit/?id=a75d021670d31388623c30e6e8f63da70d6c82af Not a huge deal, but it would be nice for notifications to match the theme. Thank you all so much for your work, I love the numix themes.

khurshid-alam commented 7 years ago

The link is giving me "Page not found".

And as of now, we do not have proper support Xfce4-notifyd (gtk3). But it is on my radar.

sjb0x49 commented 7 years ago

https://git.xfce.org/apps/xfce4-notifyd/commit/?id=a75d021670d31388623c30e6e8f63da70d6c82af Sorry about that, the editor changed the url for the link, for some reason. (you can see while hovering the first link) I probably did something wrong. Anyway this should show the commit. Thank you

ragazenta commented 6 years ago

After looking commit histories and old pull requests, I notice that xfce-notify-4.0/gtk.css had already been added (#512) but then removed (https://github.com/numixproject/numix-gtk-theme/commit/30b14f77d05389d80b395720e6603836a579edd4), it was moved into scss.

Should it be restored? But I also notice some styles are different: background-color, border-color, etc.

Xfce4-notifyd (gtk3) use xfce-notify-4.0/gtk.css to override styles on main gtk.css theme and it will appear in Configuration, CMIIW. I think the Default option in Configuration has already matched the theme.

khurshid-alam commented 6 years ago

Feel free to open a PR.