Closed k-kirill closed 6 years ago
For the second issue, I guess it's a GTK issue... Happen to me sometimes...
@k-kirill Which icon theme do you use?
@khurshid-alam it seems to be Numix
About the first issue, the following selector is used for GtkImage - play_image:
:disabled, :disabled:disabled { color: mix(#ddd,#444,0.5); }
It seems to be a GTK issue as well because the button is sensitive on playing and only image is changed on pressing the enabled "pause" icon and the disabled "play" icon is shown instead.
It doesn't happen with other apps like totem. Beside it is reproducible with other themes.
@k-kirill About radio album border : for me it doesn't show any album cover for any radio stations. Do you have any specific radio station for which it does ?
@khurshid-alam
1) However, Adwaita does not define :disabled for GtkImage, that's why it works fine for it.
2) I use the following cover art for the radio:
@k-kirill If it's there, there are some use of it....I will test a bit...If I don't find any regression I will disable it either for lollypop or globally.
It seems that it makes sense to make the GtkImage sensitive on the sensitive GtkButton. Also, turns out the second issue affects Adwaita as well. So, I added a comment in the original defect: https://github.com/gnumdk/lollypop/issues/1214#issuecomment-325114263
@k-kirill About radio album border, moving the paned view should fix the issue.
The glitches were fixed in the latest lollypop builds (0.9.300 and greater) in the aforementioned defect, so I reckon we can mark this issue as closed.
There are some visual glitches with Lollypop music player: https://github.com/gnumdk/lollypop 1) The "play" symbol icon in the header has the wrong color, though, the "pause" icon has the correct bright color. The "play" icon is painted correctly also in the fullscreen mode when not in the header. 2) The right border around clip art is missing in Radios view, though, the border is shown in All artist view.![glitches](https://user-images.githubusercontent.com/8539168/29230504-06075eb8-7eec-11e7-8bc6-0cb65840f4f2.png)
I cannot reproduce these two issues using Adwaita gtk theme.
I reported the issue for Lollypop first, but developers said to raise an issue here for the theme. https://github.com/gnumdk/lollypop/issues/1214
Environment