search

numixproject / numix-gtk-theme

A modern flat theme with a combination of light and dark elements.
GNU General Public License v3.0
1.2k stars 228 forks source link

Xfwm4: improve accessibility (wider bottom edge) #684

Closed achadwick closed 6 years ago

achadwick commented 6 years ago

After #96 got applied then rolled back as "ugly", I got disheartened and gave up. Also I've been using GNOME for a bit with its nice default theme, so I somewhat lost interest in Numix for a while. Sorry.

Let's see if we can get a reasonable compromise into Numix for Xfce users, because that helps people faster. The Xfce people would be happy for contributors to work on virtual resize grips for their compositor mode, but the urgency there among the core team isn't great (xfce bugzilla 11808).

This updated branch applies cleanly onto master again, and obsoletes the branch in the old PR. I'm happy to take suggestions and update this branch with your feedback.

Here's a little preview of what Xfce looks like with this change. This PR currently only touches the bottom border.

patch e04b059 preview

achadwick commented 6 years ago

By the way, what's the reason for the the dark dots in the top-left and top-right corners with this theme? Just something odd I noticed :smile:

corner_dot

khurshid-alam commented 6 years ago

@achadwick I have no idea about that .

But Can you also provide a screenshot for a gtk-headerbar app like nautilus or gedit ?

achadwick commented 6 years ago

@khurshid-alam No trouble: https://user-images.githubusercontent.com/61299/29916683-604c8c9a-8e37-11e7-9f57-e3963cae9fea.png.

It doesn't seem relevant to this commit, since I only touched the traditional Xfwm theme.

achadwick commented 6 years ago

@khurshid-alam Hi there - anything more needed for this one?

khurshid-alam commented 6 years ago

No. Not really. I am just waiting for @lots0logs to fix the circleci.

lots0logs commented 6 years ago

@khurshid-alam Sorry I didn't notice it was failing. I'll look into it asap!

khurshid-alam commented 6 years ago

@lots0logs

It is failing because of version mismatch when it tries to pull sass with gem.

ERROR:  Error installing sass:
    sass requires Ruby version >= 2.0.0.

We now don't need to install sass with gem. ruby-sass is available in debian stretch. So changing the command to sudo apt-get install ruby-sass should fix it.

achadwick commented 6 years ago

Ah, the mixed blessing of "all checks shall pass". I was wondering whether that was the rule here! :smile: