search

numixproject / numix-gtk-theme

A modern flat theme with a combination of light and dark elements.
GNU General Public License v3.0
1.2k stars 228 forks source link

Update xfce4-notifyd specific gtk3 style. Related to #677. #709

Closed ragazenta closed 6 years ago

ragazenta commented 6 years ago
Before After
xfce-notifyd-before xfce-notifyd-after

Gtk3 styles for xfce4-notifyd had been moved to scss in https://github.com/numixproject/numix-gtk-theme/commit/30b14f77d05389d80b395720e6603836a579edd4. But some styles is not really match to osd styles (border, border-radius) if using Default theme. I found Default/gtk.css defines some styles with low priority that will be used if that style isn't defined in main gtk theme.

I conclude that #XfceNotifyWindow selector isn't defined properly. It should be like this guide.

I only define styles based on Default/gtk.css, just copying osd styles.

Related to #677.

khurshid-alam commented 6 years ago

@ragazenta ?

khurshid-alam commented 6 years ago

@ragazenta

Thanks. Can you move your code to src/gtk-3.20/scss/apps/_xfce.scss? I think that way all xfce code remain at one place. Please test it works after you move.

Thanks.

ragazenta commented 6 years ago

@khurshid-alam

Done moving code. It works as expected.