numixproject / numix-gtk-theme

A modern flat theme with a combination of light and dark elements.
GNU General Public License v3.0
1.19k stars 227 forks source link

Numix theme broken in Debian Buster 10.3 Xfce 4.12 & Xubuntu Xfce 4.14 Desktop #742

Closed c1ph3rl1nux closed 3 years ago

c1ph3rl1nux commented 4 years ago

The Numix theme is not rendering correctly in Debian 10.3 Xfce 4.12 & Xubuntu Xfce 4.14 desktop.The side pane in thunar should be grey. Any idea how this can be fixed?

Screenshot from 2020-03-27 17-53-49

c1ph3rl1nux commented 4 years ago

Looks like it affects multiple users. See Ubuntu bug report here: https://bugs.launchpad.net/ubuntu/+source/numix-gtk-theme/+bug/1875822

khurshid-alam commented 4 years ago

Is it gtk2 or gtk3 ?

khurshid-alam commented 4 years ago

Thunar is gtk3 now and doesn't provide any node to overwrite the sidebar color from theme.

c1ph3rl1nux commented 4 years ago

But the the stock themes work just fine, greybird's side pane in thunar is light blue. It's only Numix that's broken. See screenshot below. Screenshot_2020-05-15_12-57-46 Screenshot_2020-05-15_12-50-57

darkshram commented 3 years ago

@khurshid-alam I have examined different themes with the correct sidebar colors with styles for scrolledwindow.sidebar, treeview.view and scrolledwindow.shortcuts-pane. This is an example of how this issue could be solved:

.thunar {

//
// Here goes miscellaneous unneeded(?) code for the rest of thunar layout:
//
// toolbar.horizontal button image { ... }
// scrolledwindow.standard-view { ... }
// toolbar { ... }
//

  scrolledwindow.sidebar treeview.view {
    background: $dark_sidebar_bg;
    color: $dark_sidebar_fg;

    &:selected, &:active {
      background: $selected_bg_color;
      color: $selected_fg_color;
    }
  }

  scrolledwindow.shortcuts-pane {
    border-top-width: 0;
  }
}

Just needs to replace $dark_sidebar_bg, $dark_sidebar_fg, $selected_bg_color and $selected_fg_color with the right values for Numix from _colors.scss and then add it to src/gtk-3.*/scss/apps/_xfce.scss.

$selected_bg_color --> $theme_selected_bg_color (?) $selected_fg_color --> $theme_selected_fg_color (?) $dark_sidebar_bg --> $bg_color (?) $dark_sidebar_fg --> $fg_color (?)

khurshid-alam commented 3 years ago

Thanks. Can you open a pull requests ?

darkshram commented 3 years ago

@khurshid-alam I'm going to test it first. Please, I need to know which values to use instead of $dark_sidebar_bg, $dark_sidebar_fg, $selected_bg_color and $selected_fg_color. Are the ones I tried to guess at the end of my post the right ones?

$selected_bg_color --> $theme_selected_bg_color (?) $selected_fg_color --> $theme_selected_fg_color (?) $dark_sidebar_bg --> $bg_color (?) $dark_sidebar_fg --> $fg_color (?)

darkshram commented 3 years ago

@khurshid-alam I have tested it. Seems to work, at least with gtk+-3.24.28. Seems fixed. I think this needs testing with gtk+-3.22/3.20 versions. Hope @c1ph3rl1nux may help testing.

Captura de pantalla_2021-04-02_08-02-01

Captura de pantalla_2021-04-02_07-22-33

So far, just created new file as src/gtk-3.20/scss/apps/_thunar.scss with this content:

@include exports("thunar") {
.thunar {
  scrolledwindow.sidebar treeview.view {
    background: $bg_color;
    color: $fg_color;

    &:selected, &:active {
      background: $selected_bg_color;
      color: $selected_fg_color;
    }
  }

  scrolledwindow.shortcuts-pane {
    border-top-width: 1;
  }
 }
}

And then added the following to src/gtk-3.20/scss/_widgets.scss, just before the line with @import "apps/xfce";:

@import "apps/thunar";

Repeated the same for gtk-3.0 folder and then executed make && make install.

Here is the preliminary patch: numix-gtk-theme-2.6.7-fix-thunar.tar.gz

Will test more and see if something else is needed and then will do a pull request.

c1ph3rl1nux commented 3 years ago

@darkshram Thanks for the fix. Works like a charm!